samples: bluetooth: hci_uart: Improve TX path #27917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordic-krch
requested review from
jhedberg,
joerchan and
Vudentz
as code owners
carlescufi
approved these changes
Sep 1, 2020
|
I also tested this with BlueZ without any issues. |
|
my test setup consist of two nrf52 boards, one hci_uart and second peripheral_hr and controller off. |
joerchan
approved these changes
Sep 1, 2020
| static struct net_buf *buf; | ||
| int len; | ||
|
|
||
| if (buf == NULL) { |
There was a problem hiding this comment.
Usually check with !buf (same below).
anangl
approved these changes
Sep 1, 2020
Improved TX path to use uart_fifo_fill instead of uart_poll_out Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no>
nordic-krch
force-pushed
the
hci_uart_tx_improv
branch
from
afcd7d1
to
dab4e95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved TX path to use uart_fifo_fill instead of uart_poll_out
PR takes TX part from #27581 with a bit of rework. It is using very similar approach as in
h4.c.Fixes #2955
Signed-off-by: Krzysztof Chruscinski krzysztof.chruscinski@nordicsemi.no