Bluetooth: Mesh: Virtual address memory leak #28279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trond-snekvik
added
bug
trond-snekvik
requested review from
jhedberg,
joerchan and
Vudentz
as code owners
|
Looks indeed is bug, but I think the same operation should be done in these places. 1 More, if model publish first set with label uuid, and again with mod_pub_set, memory leak also will be appear. So, should check whether each place in mod->group[] is a virtual address. |
trond-snekvik
force-pushed
the
label_memleak
branch
from
8b90d22
to
cb05337
Compare
Fixes a memory leak when a virtual address subscription is added for a model that either has this VA already, or the model has no more space for subscription addresses. Signed-off-by: Trond Einar Snekvik <Trond.Einar.Snekvik@nordicsemi.no>
trond-snekvik
force-pushed
the
label_memleak
branch
from
cb05337
to
7e49153
Compare
jhedberg
approved these changes
Sep 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a memory leak when a virtual address subscription is added for a
model that either has this VA already, or the model has no more space
for subscription addresses.
Split off from #28062 to go into 2.4.
Signed-off-by: Trond Einar Snekvik Trond.Einar.Snekvik@nordicsemi.no