Bluetooth: Mesh: split prov.c into two separate modules #28457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LingaoM
requested review from
jhedberg,
joerchan,
trond-snekvik and
Vudentz
as code owners
github-actions
bot
added
area: Bluetooth
area: Bluetooth Mesh
area: Samples
|
cc @tsvehagen |
tsvehagen
suggested changes
Sep 17, 2020
|
Marking as draft, as the diff keeps changing. Please take it out of draft state when it's ready for review. |
|
Remove draft since conflict has been solved and ready for review. |
trond-snekvik
requested changes
Oct 7, 2020
jhedberg
requested changes
Oct 7, 2020
tsvehagen
reviewed
Oct 8, 2020
trond-snekvik
requested changes
Oct 12, 2020
trond-snekvik
requested changes
Oct 15, 2020
trond-snekvik
requested changes
Oct 16, 2020
trond-snekvik
approved these changes
Oct 20, 2020
LingaoM
added a commit
to LingaoM/zephyr
that referenced
this pull request
Apr 19, 2021
Zephyr Bluetooth Mesh did not check whether the proxy message was actually sent out, so that the response message could not be received during reset. It did not solve the status callback of the proxy sending message, so a new problem was introduced after PR(zephyrproject-rtos#28457) merged. bt_mesh_prov_send(&buf, public_key_sent)) This PR will try to solve the above problem, and will fix the problem due to thread competition, and PR(26668) will not be necessary. Compared with PR(zephyrproject-rtos#30138), it no longer consumes extra RAM space and supports synchronization of group addresses Signed-off-by: Lingao Meng <menglingao@xiaomi.com>
LingaoM
added a commit
to LingaoM/zephyr
that referenced
this pull request
Jun 11, 2021
Zephyr Bluetooth Mesh did not check whether the proxy message was actually sent out, so that the response message could not be received during reset. It did not solve the status callback of the proxy sending message, so a new problem was introduced after PR(zephyrproject-rtos#28457) merged. bt_mesh_prov_send(&buf, public_key_sent)) This PR will try to solve the above problem, and will fix the problem due to thread competition, and PR(zephyrproject-rtos#26668) will not be necessary. Compared with PR(zephyrproject-rtos#30138), it no longer consumes extra RAM space and supports synchronization of group addresses Signed-off-by: Lingao Meng <menglingao@xiaomi.com>
jhedberg
pushed a commit
that referenced
this pull request
Jun 14, 2021
Zephyr Bluetooth Mesh did not check whether the proxy message was actually sent out, so that the response message could not be received during reset. It did not solve the status callback of the proxy sending message, so a new problem was introduced after PR(#28457) merged. bt_mesh_prov_send(&buf, public_key_sent)) This PR will try to solve the above problem, and will fix the problem due to thread competition, and PR(#26668) will not be necessary. Compared with PR(#30138), it no longer consumes extra RAM space and supports synchronization of group addresses Signed-off-by: Lingao Meng <menglingao@xiaomi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version coupled
provisioneranddeviceprovisioning in a source fileprov.c.For only supporting device or provisioner, this will not be compiled separately, and coupling
in a file will cause unclear logic, which is not conducive to later maintenance, for example, support for remote provisioning.
Now it is divided into three files and managed separately, which is called prov.c prov_device.c and provisioner.c.
Add
CONFIG_BT_MESH_PROV_DEVICEin Kconfig to control whether device provisioning is supported.Use
CONFIG_BT_MESH_PROVISIONERin Kconfig to control whether provisioner role is supported.Add support for all provisioner OOB authentication implementations.
Signed-off-by: Lingao Meng mengabc1086@gmail.com