-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nRF SoCs: Power consumption related fixes #29409
Merged
carlescufi
merged 2 commits into
zephyrproject-rtos:master
from
anangl:power_consumption_related_fixes
Oct 22, 2020
Merged
nRF SoCs: Power consumption related fixes #29409
carlescufi
merged 2 commits into
zephyrproject-rtos:master
from
anangl:power_consumption_related_fixes
Oct 22, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial configuration provided for the nrfx_power driver cannot contain just default values, as that mean that DC/DC converters are to be disabled, while those converters may be (and they actually are by default for many boards) enabled through Kconfig. Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
a016df5
to
1fbf8e9
Compare
jfischer-no
approved these changes
Oct 21, 2020
pdunaj
approved these changes
Oct 22, 2020
eobalski
approved these changes
Oct 22, 2020
carlescufi
approved these changes
Oct 22, 2020
Update the hal_nordic module revision to get the following commit: nrf_power: Fix implementation of workaround for nRF52 anomaly 197 Since the workaround increases power consumption in System ON IDLE, it should be applied only when the DC/DC converter for REG0 stage is to be enabled, not regardless of the applied setting as it was done so far. Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
1fbf8e9
to
bf8ea50
Compare
Updated revision of the hal_nordic module. |
anangl
added a commit
to anangl/sdk-zephyr
that referenced
this pull request
Oct 22, 2020
driver configuration Upstream PR: zephyrproject-rtos/zephyr#29409 The initial configuration provided for the nrfx_power driver cannot contain just default values, as that mean that DC/DC converters are to be disabled, while those converters may be (and they actually are by default for many boards) enabled through Kconfig. Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
anangl
added a commit
to anangl/sdk-zephyr
that referenced
this pull request
Oct 22, 2020
anomaly 197 in nrf_power Upstream PR: zephyrproject-rtos/zephyr#29409 Update the hal_nordic module revision to get the following commit: nrf_power: Fix implementation of workaround for nRF52 anomaly 197 Since the workaround increases power consumption in System ON IDLE, it should be applied only when the DC/DC converter for REG0 stage is to be enabled, not regardless of the applied setting as it was done so far. Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
tejlmand
pushed a commit
to tejlmand/fw-nrfconnect-zephyr-1
that referenced
this pull request
Oct 26, 2020
driver configuration Upstream PR: zephyrproject-rtos/zephyr#29409 The initial configuration provided for the nrfx_power driver cannot contain just default values, as that mean that DC/DC converters are to be disabled, while those converters may be (and they actually are by default for many boards) enabled through Kconfig. Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
tejlmand
pushed a commit
to tejlmand/fw-nrfconnect-zephyr-1
that referenced
this pull request
Oct 26, 2020
anomaly 197 in nrf_power Upstream PR: zephyrproject-rtos/zephyr#29409 Update the hal_nordic module revision to get the following commit: nrf_power: Fix implementation of workaround for nRF52 anomaly 197 Since the workaround increases power consumption in System ON IDLE, it should be applied only when the DC/DC converter for REG0 stage is to be enabled, not regardless of the applied setting as it was done so far. Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
carlescufi
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Oct 26, 2020
driver configuration Upstream PR: zephyrproject-rtos/zephyr#29409 The initial configuration provided for the nrfx_power driver cannot contain just default values, as that mean that DC/DC converters are to be disabled, while those converters may be (and they actually are by default for many boards) enabled through Kconfig. Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
carlescufi
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Oct 26, 2020
anomaly 197 in nrf_power Upstream PR: zephyrproject-rtos/zephyr#29409 Update the hal_nordic module revision to get the following commit: nrf_power: Fix implementation of workaround for nRF52 anomaly 197 Since the workaround increases power consumption in System ON IDLE, it should be applied only when the DC/DC converter for REG0 stage is to be enabled, not regardless of the applied setting as it was done so far. Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
mbolivar-nordic
pushed a commit
to mbolivar-nordic/sdk-zephyr
that referenced
this pull request
Oct 26, 2020
driver configuration Upstream PR: zephyrproject-rtos/zephyr#29409 The initial configuration provided for the nrfx_power driver cannot contain just default values, as that mean that DC/DC converters are to be disabled, while those converters may be (and they actually are by default for many boards) enabled through Kconfig. Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no> (cherry picked from commit 6761718)
mbolivar-nordic
pushed a commit
to mbolivar-nordic/sdk-zephyr
that referenced
this pull request
Oct 26, 2020
anomaly 197 in nrf_power Upstream PR: zephyrproject-rtos/zephyr#29409 Update the hal_nordic module revision to get the following commit: nrf_power: Fix implementation of workaround for nRF52 anomaly 197 Since the workaround increases power consumption in System ON IDLE, it should be applied only when the DC/DC converter for REG0 stage is to be enabled, not regardless of the applied setting as it was done so far. Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no> (cherry picked from commit 457b290)
ioannisg
pushed a commit
to ioannisg/fw-nrfconnect-zephyr-1
that referenced
this pull request
Nov 18, 2020
anomaly 197 in nrf_power Upstream PR: zephyrproject-rtos/zephyr#29409 Update the hal_nordic module revision to get the following commit: nrf_power: Fix implementation of workaround for nRF52 anomaly 197 Since the workaround increases power consumption in System ON IDLE, it should be applied only when the DC/DC converter for REG0 stage is to be enabled, not regardless of the applied setting as it was done so far. Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no> (cherry picked from commit 457b290) (cherry picked from commit 105a1b9) Signed-off-by: Ioannis Glaropoulos <Ioannis.Glaropoulos@nordicsemi.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: Drivers
area: Modules
bug
The issue is a bug, or the PR is fixing a bug
platform: nRF
Nordic nRFx
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
drivers: usb_dc_nrfx: Correct the nrfx_power driver configuration
The initial configuration provided for the nrfx_power driver cannot
contain just default values, as that mean that DC/DC converters are
to be disabled, while those converters may be (and they actually are
by default for many boards) enabled through Kconfig.
Update hal_nordic module to:
nrf_power: Fix implementation of workaround for nRF52 anomaly 197
The initial configuration provided for the nrfx_power driver cannot
contain just default values, as that mean that DC/DC converters are
to be disabled, while those converters may be (and they actually are
by default for many boards) enabled through Kconfig.
See zephyrproject-rtos/hal_nordic#62