Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nRF SoCs: Power consumption related fixes #29409

Merged

Conversation

anangl
Copy link
Member

@anangl anangl commented Oct 21, 2020

drivers: usb_dc_nrfx: Correct the nrfx_power driver configuration

The initial configuration provided for the nrfx_power driver cannot
contain just default values, as that mean that DC/DC converters are
to be disabled, while those converters may be (and they actually are
by default for many boards) enabled through Kconfig.

Update hal_nordic module to:
nrf_power: Fix implementation of workaround for nRF52 anomaly 197

The initial configuration provided for the nrfx_power driver cannot
contain just default values, as that mean that DC/DC converters are
to be disabled, while those converters may be (and they actually are
by default for many boards) enabled through Kconfig.

See zephyrproject-rtos/hal_nordic#62

@anangl anangl added bug The issue is a bug, or the PR is fixing a bug area: Drivers platform: nRF Nordic nRFx area: Modules labels Oct 21, 2020
The initial configuration provided for the nrfx_power driver cannot
contain just default values, as that mean that DC/DC converters are
to be disabled, while those converters may be (and they actually are
by default for many boards) enabled through Kconfig.

Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
@anangl anangl force-pushed the power_consumption_related_fixes branch from a016df5 to 1fbf8e9 Compare October 21, 2020 16:10
@anangl anangl added the DNM This PR should not be merged (Do Not Merge) label Oct 21, 2020
Update the hal_nordic module revision to get the following commit:

nrf_power: Fix implementation of workaround for nRF52 anomaly 197

Since the workaround increases power consumption in System ON IDLE,
it should be applied only when the DC/DC converter for REG0 stage is
to be enabled, not regardless of the applied setting as it was done
so far.

Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
@anangl anangl force-pushed the power_consumption_related_fixes branch from 1fbf8e9 to bf8ea50 Compare October 22, 2020 11:01
@anangl anangl removed the DNM This PR should not be merged (Do Not Merge) label Oct 22, 2020
@anangl
Copy link
Member Author

anangl commented Oct 22, 2020

Updated revision of the hal_nordic module.

anangl added a commit to anangl/sdk-zephyr that referenced this pull request Oct 22, 2020
driver configuration

Upstream PR: zephyrproject-rtos/zephyr#29409

The initial configuration provided for the nrfx_power driver cannot
contain just default values, as that mean that DC/DC converters are
to be disabled, while those converters may be (and they actually are
by default for many boards) enabled through Kconfig.

Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
anangl added a commit to anangl/sdk-zephyr that referenced this pull request Oct 22, 2020
anomaly 197 in nrf_power

Upstream PR: zephyrproject-rtos/zephyr#29409

Update the hal_nordic module revision to get the following commit:

nrf_power: Fix implementation of workaround for nRF52 anomaly 197

Since the workaround increases power consumption in System ON IDLE,
it should be applied only when the DC/DC converter for REG0 stage is
to be enabled, not regardless of the applied setting as it was done
so far.

Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
@carlescufi carlescufi merged commit f6042bb into zephyrproject-rtos:master Oct 22, 2020
@anangl anangl deleted the power_consumption_related_fixes branch October 22, 2020 12:10
tejlmand pushed a commit to tejlmand/fw-nrfconnect-zephyr-1 that referenced this pull request Oct 26, 2020
driver configuration

Upstream PR: zephyrproject-rtos/zephyr#29409

The initial configuration provided for the nrfx_power driver cannot
contain just default values, as that mean that DC/DC converters are
to be disabled, while those converters may be (and they actually are
by default for many boards) enabled through Kconfig.

Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
tejlmand pushed a commit to tejlmand/fw-nrfconnect-zephyr-1 that referenced this pull request Oct 26, 2020
anomaly 197 in nrf_power

Upstream PR: zephyrproject-rtos/zephyr#29409

Update the hal_nordic module revision to get the following commit:

nrf_power: Fix implementation of workaround for nRF52 anomaly 197

Since the workaround increases power consumption in System ON IDLE,
it should be applied only when the DC/DC converter for REG0 stage is
to be enabled, not regardless of the applied setting as it was done
so far.

Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
carlescufi pushed a commit to nrfconnect/sdk-zephyr that referenced this pull request Oct 26, 2020
driver configuration

Upstream PR: zephyrproject-rtos/zephyr#29409

The initial configuration provided for the nrfx_power driver cannot
contain just default values, as that mean that DC/DC converters are
to be disabled, while those converters may be (and they actually are
by default for many boards) enabled through Kconfig.

Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
carlescufi pushed a commit to nrfconnect/sdk-zephyr that referenced this pull request Oct 26, 2020
anomaly 197 in nrf_power

Upstream PR: zephyrproject-rtos/zephyr#29409

Update the hal_nordic module revision to get the following commit:

nrf_power: Fix implementation of workaround for nRF52 anomaly 197

Since the workaround increases power consumption in System ON IDLE,
it should be applied only when the DC/DC converter for REG0 stage is
to be enabled, not regardless of the applied setting as it was done
so far.

Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
mbolivar-nordic pushed a commit to mbolivar-nordic/sdk-zephyr that referenced this pull request Oct 26, 2020
driver configuration

Upstream PR: zephyrproject-rtos/zephyr#29409

The initial configuration provided for the nrfx_power driver cannot
contain just default values, as that mean that DC/DC converters are
to be disabled, while those converters may be (and they actually are
by default for many boards) enabled through Kconfig.

Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
(cherry picked from commit 6761718)
mbolivar-nordic pushed a commit to mbolivar-nordic/sdk-zephyr that referenced this pull request Oct 26, 2020
anomaly 197 in nrf_power

Upstream PR: zephyrproject-rtos/zephyr#29409

Update the hal_nordic module revision to get the following commit:

nrf_power: Fix implementation of workaround for nRF52 anomaly 197

Since the workaround increases power consumption in System ON IDLE,
it should be applied only when the DC/DC converter for REG0 stage is
to be enabled, not regardless of the applied setting as it was done
so far.

Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
(cherry picked from commit 457b290)
ioannisg pushed a commit to ioannisg/fw-nrfconnect-zephyr-1 that referenced this pull request Nov 18, 2020
anomaly 197 in nrf_power

Upstream PR: zephyrproject-rtos/zephyr#29409

Update the hal_nordic module revision to get the following commit:

nrf_power: Fix implementation of workaround for nRF52 anomaly 197

Since the workaround increases power consumption in System ON IDLE,
it should be applied only when the DC/DC converter for REG0 stage is
to be enabled, not regardless of the applied setting as it was done
so far.

Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
(cherry picked from commit 457b290)
(cherry picked from commit 105a1b9)
Signed-off-by: Ioannis Glaropoulos <Ioannis.Glaropoulos@nordicsemi.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Drivers area: Modules bug The issue is a bug, or the PR is fixing a bug platform: nRF Nordic nRFx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants