[RFC] Mcuboot XIP Support for Zephyr #29974

de-nordic · 2020-11-12T15:30:54Z

Provided script will automatically build alternative slot application.

Invocation:
python3 zephyr/scripts/direct_xip.py <original_build>

TODO:

add destination path selection instead of using harcoded one
error/exception handling

Kconfig.zephyr

Laczen · 2020-11-16T10:47:37Z

@de-nordic, I don't think it is required to do this change, correct usage of chosen partition allows to generate the correct image. The chosen partition info also has the required data to be passed to imgtool and to dfu-util/nrfjprog/...
To allow support for a bootloader (not only mcuboot) there are only two required pieces of info for a application image: where it will be placed in flash (partition offset) and where the image starts (unencrypted, uncompressed, ...): this is the partition offset + a image header size.

Easier support for "downloading" using dfu-util could be achieved by adding the location where the binary should be placed in flash to the header info, in that case the dfu "server" could read in the header and decide where to place it or to reject it. This is much more flexible that selecting alt-0 or alt-1 (BTW, selecting alt-0 to "upload" from flash should be disallowed). When using a "hex"-loader this is maybe less required, but still usefull for the bootloader to distinguish between execute or move.

de-nordic · 2020-11-16T10:59:55Z

Easier support for "downloading" using dfu-util could be achieved by adding the location where the binary should be placed in flash to the header info in that case the dfu "server" could read in the header and decide where to place it or to reject it.

Yes, but you are talking abut hi-end solution, I am still trying to build things for two slots. You may add that comment to the original issue reported here: #27673.

But yes, it would be nice to add header that would identify the slot of binary and allow dfu client to reject it citing the problem, or even pack two binaries together (one for each slot) and allow dft to negotiate which one will go in.

I will try with zephyr.dfu-code-partition that is supposed to be set to the slot the application will be uploaded to.
The combination of zephyr,code-partition and zephyr, dfu-code-partition, or lack of the former one, would decide whether application is built for dual slot bootable device, XIP dual boot device or single slot device.

Laczen · 2020-11-16T11:22:51Z

@de-nordic, maybe I am missing something, I was thinking you are trying to create a image to be executed from slot1. This could be done by setting the chosen partition to slot1 (or image1) nothing more. But then again, maybe you are trying to achieve something else.

nandojve · 2020-12-01T14:36:34Z

Hi folks, I noted this improvement and have couple questions:

How MCUboot will handle 3 or 4 images, or even more?

I mean, there are work on Zephyr to enable NS and SE images (non secure and secure images). These are two independent partitions + at least another one as temporary storage (scenario 1). So, how MCUboot + Zephyr will handle this ? I imagine XIP is essential for lots of platforms and there is a special case, i.MX-RT that only have external memory. Having two images on a single bin (scenario 2) is an alternative but can be impractical with LWPAN. My firsts tests with BLE IPSP (PC <-> nRF) needs around 30min to download and update 1 image with minimal resources to run the example without mesh and only 2 nodes.

Since there will be needed work to change the current dual image to a new thing, would be interesting have a infrastructure that allows multi-image support, or something that address this current/future scenario?

Sorry if this is not the right place to add both questions but it seemed opportune to raise them.

CC: @otavio

utzig · 2020-12-01T17:46:21Z

How MCUboot will handle 3 or 4 images, or even more?

The mcumgr CLI app already has a flag to choose the image pair where to upload, image upload -n <image-number>, which can be used to choose between S/NS, but this currently uploads in a fixed slot. I don't remember if the mcumgr library supports this, but MCUboot surely does. With the XIP support it will probably also get an extra flag for the slot number. Then a user will have control of what image pair and slot a particular image should be uploaded to.

nvlsianpu

Did you consider to keep working usb dfu class when it is part of mcuboot in single application-slot-mode?

nvlsianpu · 2020-12-07T16:19:16Z

subsys/usb/class/usb_dfu.c

@@ -344,7 +353,7 @@ static void dfu_reset_counters(void)
 {
 	dfu_data.bytes_sent = 0U;
 	dfu_data.block_nr = 0U;
-	if (flash_img_init(&dfu_data.ctx)) {
+	if (flash_img_init_id(&dfu_data.ctx, UPDATEABLE_FLASH_IMG_ID)) {


why this is not applied in dfu_data declaration?

The script is intended to be run on already, successfully, compleated build to generate build for alternative slot. Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>

github-actions · 2021-04-27T00:30:03Z

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

github-actions · 2021-07-14T00:29:55Z

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

github-actions · 2021-09-13T00:29:16Z

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

github-actions · 2021-11-13T00:28:56Z

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

tejlmand · 2021-12-10T11:57:22Z

@de-nordic please take a look here: #40555 I believe the approach in that RFC will be very suitable for this kind of work you need to do here.

de-nordic · 2021-12-13T15:31:00Z

@de-nordic please take a look here: #40555 I believe the approach in that RFC will be very suitable for this kind of work you need to do here.

Thanks, I will take a look.

github-actions · 2022-02-12T00:29:35Z

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

de-nordic requested a review from nvlsianpu November 12, 2020 15:30

github-actions bot added the area: Kconfig label Nov 12, 2020

This comment has been minimized.

Sign in to view

de-nordic changed the title ~~kconfig: Allow selecting of DTS partition for application code~~ kconfig: Allow selecting DTS partition for application code Nov 12, 2020

de-nordic force-pushed the xip-support branch from 890eca4 to 03b7c61 Compare November 12, 2020 15:51

utzig requested changes Nov 13, 2020

View reviewed changes

Kconfig.zephyr Outdated Show resolved Hide resolved

Kconfig.zephyr Outdated Show resolved Hide resolved

Kconfig.zephyr Outdated Show resolved Hide resolved

Kconfig.zephyr Outdated Show resolved Hide resolved

de-nordic changed the title ~~kconfig: Allow selecting DTS partition for application code~~ [RFC] Mcuboot XIP Support for Zephyr Nov 16, 2020

de-nordic force-pushed the xip-support branch from 03b7c61 to 0dda7ab Compare November 17, 2020 16:05

github-actions bot added area: Documentation area: native port Host native arch port (native_posix) area: Tests Issues related to a particular existing or missing test labels Nov 17, 2020

This was referenced Nov 18, 2020

dfu: mcuboot: allow only to erase secondary slot #30060

Closed

zephyr: add an option to use GPIO to enable USB DFU. mcu-tools/mcuboot#882

Merged

de-nordic force-pushed the xip-support branch 2 times, most recently from 45ad6ec to 59e7873 Compare December 1, 2020 13:47

de-nordic force-pushed the xip-support branch from 59e7873 to 69e7312 Compare December 1, 2020 14:41

nvlsianpu reviewed Dec 7, 2020

View reviewed changes

nvlsianpu mentioned this pull request Dec 9, 2020

boot_set_confirmed() need to be addapted for direct-xip mcu-tools/mcuboot#897

Closed

This was referenced Dec 10, 2020

[RFC][DNM] imgtool: Add support for setting fixed ROM address into image header zephyrproject-rtos/mcuboot#40

Closed

[RFC][DNM] zephyr: Add support for image ROM address verification zephyrproject-rtos/mcumgr#33

Closed

github-actions bot added area: Modules manifest west manifest-mcuboot manifest-mcumgr labels Dec 10, 2020

de-nordic force-pushed the xip-support branch 5 times, most recently from 9646814 to f73ba93 Compare January 25, 2021 12:31

de-nordic force-pushed the xip-support branch from f73ba93 to fcbf4ab Compare February 4, 2021 13:11

de-nordic requested a review from tejlmand February 5, 2021 08:05

de-nordic force-pushed the xip-support branch 3 times, most recently from 5426cad to f2d788a Compare February 10, 2021 14:41

scripts: direct_xip.py alternative Direct-XIP application generator

ed09c90

The script is intended to be run on already, successfully, compleated build to generate build for alternative slot. Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>

de-nordic force-pushed the xip-support branch from f2d788a to ed09c90 Compare February 25, 2021 16:00

github-actions bot added the Stale label Apr 27, 2021

de-nordic removed the Stale label Apr 27, 2021

de-nordic mentioned this pull request May 13, 2021

RFC: memory regions from devicetree & explicit code locations #33656

Closed

github-actions bot added the Stale label Jul 14, 2021

de-nordic removed the Stale label Jul 14, 2021

github-actions bot added the Stale label Sep 13, 2021

de-nordic removed the Stale label Sep 13, 2021

github-actions bot added the Stale label Nov 13, 2021

de-nordic removed the Stale label Nov 15, 2021

github-actions bot added the Stale label Feb 12, 2022

github-actions bot closed this Feb 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RFC] Mcuboot XIP Support for Zephyr #29974

[RFC] Mcuboot XIP Support for Zephyr #29974

de-nordic commented Nov 12, 2020 •

edited

This comment has been minimized.

Laczen commented Nov 16, 2020 •

edited

de-nordic commented Nov 16, 2020

Laczen commented Nov 16, 2020

nandojve commented Dec 1, 2020

utzig commented Dec 1, 2020

nvlsianpu left a comment

nvlsianpu Dec 7, 2020

github-actions bot commented Apr 27, 2021

github-actions bot commented Jul 14, 2021

github-actions bot commented Sep 13, 2021

github-actions bot commented Nov 13, 2021

tejlmand commented Dec 10, 2021

de-nordic commented Dec 13, 2021

github-actions bot commented Feb 12, 2022

[RFC] Mcuboot XIP Support for Zephyr #29974

[RFC] Mcuboot XIP Support for Zephyr #29974

Conversation

de-nordic commented Nov 12, 2020 • edited

This comment has been minimized.

Laczen commented Nov 16, 2020 • edited

de-nordic commented Nov 16, 2020

Laczen commented Nov 16, 2020

nandojve commented Dec 1, 2020

utzig commented Dec 1, 2020

nvlsianpu left a comment

Choose a reason for hiding this comment

nvlsianpu Dec 7, 2020

Choose a reason for hiding this comment

github-actions bot commented Apr 27, 2021

github-actions bot commented Jul 14, 2021

github-actions bot commented Sep 13, 2021

github-actions bot commented Nov 13, 2021

tejlmand commented Dec 10, 2021

de-nordic commented Dec 13, 2021

github-actions bot commented Feb 12, 2022

de-nordic commented Nov 12, 2020 •

edited

Laczen commented Nov 16, 2020 •

edited