Tfm clean up kconfig #30321
Merged
Tfm clean up kconfig #30321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ioannisg
commented
Nov 30, 2020
•
ioannisg
commented
- Cleanup the BUILD_WITH_TFM option definition in Kconfig.tfm removing redundant options
- Remove the overriding of NUM_PRIORITIES which is not needed.
- Add proper dependencies and imply statements on BUILD_WITH_TFM
- Code Owners for Kconfig.tfm (module)
| @@ -20,12 +20,6 @@ config TFM_BOARD | |||
|
|
|||
| menuconfig BUILD_WITH_TFM | |||
| bool "Build with TF-M as the Secure Execution Environment" | |||
| select CMSIS_RTOS_V2 | |||
There was a problem hiding this comment.
If it's truly not needed, you can remove the NUM_PREEMPT_PRIORITIES below as well.
There was a problem hiding this comment.
Has this been tested with the two TF-M samples? I'll do so myself later today, but wanted to check if someone has already verified this isn't required any longer since it previously was for IPC support (circa TFM 1.1).
There was a problem hiding this comment.
Yeap, I did that for mps2 an521.
When we select BUILD_WITH_TFM we do not really need to enable by default the options THREAD_NAME, THREAD_STACK_INFO, INIT_STACKS and THREAD_MONITOR, so we can clean them up. We also remove CMSIS_RTOS_V2 for the same reason. We also cleanup the default value for NUM_PREEMPT_PRIORITIES, which does not seem to be needed. Signed-off-by: Ioannis Glaropoulos <Ioannis.Glaropoulos@nordicsemi.no>
BUILD_WITH_TFM needs to depend on ARM_TRUSTZONE_M, which is selected by the SoC or Board definition. In addition to that we add an imply statement for INIT_ARCH_HW_AT_BOOT because Zephyr will be chain-loaded by TF-M, and needs to cleanup its core ARCH registers that might be left in non-reset state. Signed-off-by: Ioannis Glaropoulos <Ioannis.Glaropoulos@nordicsemi.no>
Add the TFM Module maintainers as code owners for Kconfig.tfm. Signed-off-by: Ioannis Glaropoulos <Ioannis.Glaropoulos@nordicsemi.no>
ioannisg
force-pushed
the
tfm_clean_up_kconfig
branch
from
11124f2
to
d9bf718
Compare
ioannisg
commented
Nov 30, 2020
| @@ -45,10 +41,6 @@ menuconfig BUILD_WITH_TFM | |||
|
|
|||
| if BUILD_WITH_TFM | |||
|
|
|||
| config NUM_PREEMPT_PRIORITIES | |||
There was a problem hiding this comment.
Does not seem to be needed @oyvindronningstad so I removed that as well.
erwango
approved these changes
Dec 1, 2020
oyvindronningstad
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.