Add PSCI driver #30911
Merged
Add PSCI driver #30911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlocaione
requested review from
npitre,
tbursztyka,
ioannisg,
andrewboie,
MrVan,
stephanosio,
sandeepbrcm,
Abhishek-brcm,
dcpleung,
amergnat and
wentongwu
carlocaione
requested review from
carlescufi,
galak,
MaureenHelm and
nashif
as code owners
github-actions
bot
added
area: API
carlocaione
force-pushed
the
psci
branch
2 times, most recently
from
bd895d3
to
f72a81c
Compare
sandeepbrcm
approved these changes
Dec 21, 2020
MrVan
approved these changes
Dec 22, 2020
|
@carlocaione Thanks for adding psci support, your code looks good to me. Approved. |
Merged
|
Can we merge this? |
MaureenHelm
approved these changes
Jan 4, 2021
andrewboie
reviewed
Jan 5, 2021
andrewboie
reviewed
Jan 5, 2021
Firmware implementing the PSCI functions described in ARM document
number ARM DEN 0022A ("Power State Coordination Interface System
Software on ARM processors") can be used by Zephyr to initiate various
CPU-centric power operations.
It is needed for virtualization, it is used to coordinate OSes and
hypervisors and it provides the functions used for SMP bring-up such as
CPU_ON and CPU_OFF.
A new PSCI driver is introduced to setup a proper subsystem used to
communicate with the PSCI firmware, implementing the basic operations:
get_version, cpu_on, cpu_off and affinity_info.
The current implementation only supports PSCI 0.2 and PSCI 1.0
The PSCI conduit (SMC or HVC) is setup reading the corresponding
property in the DTS node.
Signed-off-by: Carlo Caione <ccaione@baylibre.com>
@andrewboie I addressed your points. The only API I couldn't test was |
Add a simple test to the the PSCI driver Signed-off-by: Carlo Caione <ccaione@baylibre.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit of rationale behind this PR.
@MrVan submitted in #30676 the PR to enable SMP on AArch64. As I wrote in a review to that PR I do not particularly like the approach of using arch-specific code to interface with the PSCI firmware.
PSCI interface needs a proper driver that uses the DTS to detect the correct parameters, especially the conduit (and currently only that). This is particularly important because the choice of having SMC or HVC as conduit really depends on whether we are running an hypervisor or not in EL2, so this must be something configurable at DTS (board) level.
So here it is a proper PSCI driver with support for PSCI 0.2 and PSCI 1.0, enabled using the DT and also a tiny test to make sure that everything is working correctly.