dts: Add binding and nodes representing Nordic ECB peripheral #30930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anangl
added
area: Devicetree
platform: nRF
galak
approved these changes
Dec 21, 2020
|
Rebased and updated accordingly (used |
mbolivar-nordic
approved these changes
Jan 13, 2021
ioannisg
approved these changes
Jan 13, 2021
| bool "nRF AES electronic codebook mode encryption" | ||
| depends on HAS_HW_NRF_ECB && !BT_CTLR | ||
| depends on $(dt_compat_enabled,$(DT_COMPAT_NORDIC_NRF_ECB)) | ||
| depends on !BT_CTLR |
There was a problem hiding this comment.
@anangl should we have a comment explaining why !BT_CTRL is a dependency?
There was a problem hiding this comment.
I know it was un-commented, already, but perhaps we could add now the clarification.
There was a problem hiding this comment.
@ioannisg I added a note that explains this dependency. Please check if it is acceptable.
Since MDK was updated and now it contains the definition of QDEC peripheral for nRF52805, the DT node representing this peripheral can be processed normally. Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
Add binding for the Nordic ECB (AES electronic codebook mode encryption) peripheral and corresponding devicetree nodes for nRF SoCs that feature this peripheral. Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
Convert the driver so that it creates its instance basing on DT. Remove no longer needed Kconfig option CRYPTO_NRF_ECB_NAME. Also update accordingly the crypto sample. Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
Add check that validates that the base addresses specified in DT nodes representing the ECB peripheral match the addresses of that peripheral defined in MDK. Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
|
Rebased on master, to solve the problem with reported undefined Kconfig options being referenced (those from the recently added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds binding for the Nordic ECB (AES electronic codebook mode encryption) peripheral and corresponding devicetree nodes for nRF SoCs that feature this peripheral. The
crypto_nrf_ecbdriver is converted so that it creates its instance basing on DT, and theCRYPTO_NRF_ECB_NAMEKconfig option is removed as no longer needed.The first commit does an additional minor cleanup in one of the files modified by this PR.