Bluetooth: L2CAP: Fix missing buffer length check for sdu_len #32588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only compile tested, but seemed trivial enough.. |
joerchan
reviewed
Feb 24, 2021
We should verify that the buffer has sufficient data before attempting to parse the SDU length field. If we get a too short packet just disconnect the channel. Fixes zephyrproject-rtos#32497 Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
jhedberg
force-pushed
the
l2cap_sdu_len
branch
from
3555314
to
4a0e191
Compare
joerchan
approved these changes
Feb 24, 2021
This was referenced Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should verify that the buffer has sufficient data before attempting
to parse the SDU length field.
Fixes #32497
Signed-off-by: Johan Hedberg johan.hedberg@intel.com