nRF: change UART DT pinmux properties to tx-gpios, rx-gpios, rts-gpios, cts-gpios #32653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbolivar-nordic
requested review from
anangl,
carlescufi,
galak,
idlethread,
ioannisg,
jhedberg,
joerchan,
lemrey,
MaureenHelm,
Mierunski,
nashif,
Navin-Sankar and
Vudentz
as code owners
|
Blocked on #31965; only the final 3 commits are truly part of this PR. |
zephyrbot
added
area: I2C
platform: nRF
zephyrbot
requested review from
avisconti,
dcpleung and
pabigot
and removed request for
Navin-Sankar
|
I found some RST docs that still reference the old properties. I'll update those too. |
joerchan
approved these changes
Mar 1, 2021
mbolivar-nordic
force-pushed
the
dt-nrf-uart-gpios
branch
2 times, most recently
from
541aee6
to
ee0138a
Compare
mbolivar-nordic
added
DNM
|
Rebased on master now that #31965 is merged. Driver changes are ready for review. DNM for now since it has increased the BK parallelism and I still need to update the RST files. That will require pulling some additional docs patches out of an older PR. |
In addition to the tx-pin, rx-pin, rts-pin, and cts-pin properties in
the devicetree, provide new tx-gpios, rx-gpios, rts-gpios, and
cts-gpios properties.
This lets the user specify TX and RX like this:
&uart0 {
tx-gpios = <&gpio0 1 0>;
rx-gpios = <&gpio1 4 0>;
};
Instead of having to use:
&uart0 {
tx-pin = <1>;
rx-pin = <36>;
};
Provide error checking and understandable error messages for invalid
configurations.
Signed-off-by: Martí Bolívar <marti.bolivar@nordicsemi.no>
Convert uses of the following properties to these equivalents:
tx-pin -> tx-gpios
rx-pin -> rx-gpios
rts-pin -> rts-gpios
cts-pin -> cts-gpios
Done with a script except for the /delete-property/ line in the
samples. Sample, board, and test changes are combined for bisectability.
Signed-off-by: Martí Bolívar <marti.bolivar@nordicsemi.no>
Deprecate the no longer used properties. Signed-off-by: Martí Bolívar <marti.bolivar@nordicsemi.no>
Trying to pass CI. Signed-off-by: Martí Bolívar <marti.bolivar@nordicsemi.no>
mbolivar-nordic
force-pushed
the
dt-nrf-uart-gpios
branch
from
ee0138a
to
7f27e81
Compare
|
@mbolivar-nordic please rebase |
|
Abandoning due to #31965 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues work begun in #31965 by making a similar change to UART bindings.
A prototypical example is to specify TX and RX like this in an overlay:
Instead of:
The old style is still supported, but at most one property in each pair can be given. Provide error checking and understandable error messages for invalid configurations.