twister: Improve handling of errors while flashing device #33214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakehuang
approved these changes
Mar 11, 2021
nashif
requested changes
Mar 11, 2021
scripts/pylib/twister/twisterlib.py
Outdated
| @@ -814,6 +814,8 @@ def handle(self): | |||
| self.instance.reason = "Device issue (Flash?)" | |||
| with open(d_log, "w") as dlog_fp: | |||
| dlog_fp.write(stderr.decode()) | |||
| os.write(write_pipe, b'x') # halt the thread | |||
| out_state = "Flash error" | |||
scripts/pylib/twister/twisterlib.py
Outdated
| for c in self.instance.testcase.cases: | ||
| if c not in harness.tests: | ||
| harness.tests[c] = "BLOCK" | ||
|
|
||
| self.instance.reason = "Timeout" | ||
| self.instance.reason = out_state |
There was a problem hiding this comment.
here, translate the state to a readable reason string.
The patch improves handling runners errors from flashing. It add thread termination in case of process returning non 0 exit code. Before, even though the error was returned, a thread was not terminated and test ended only after timeout termination. The patch also adds information about the failure reason to the reports Signed-off-by: Maciej Perkowski <Maciej.Perkowski@nordicsemi.no>
PerMac
force-pushed
the
fix/runner_error_handeling
branch
from
f3ee308
to
0e7dbd5
Compare
|
@nashif requested changes applied. |
nashif
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch improves handling runners errors from flashing. It
add thread termination in case of process returning non 0 exit
code. Before, even though the error was returned,
a thread was not terminated and test ended
only after timeout termination. The patch also adds information about
the failure reason to the reports
Signed-off-by: Maciej Perkowski Maciej.Perkowski@nordicsemi.no