Revert nordic I2C sda-gpios, scl-gpios changes #34356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbolivar-nordic
requested review from
anangl,
carlescufi,
galak,
idlethread,
ioannisg,
lemrey,
MaureenHelm and
Navin-Sankar
as code owners
jfischer-no
approved these changes
Apr 16, 2021
anangl
approved these changes
Apr 19, 2021
These changes turn out to have been incompatible with the way pinctrl drivers are going to work, so we need to go back to what we had before until we can agree on a better approach. Squash of the following reverts: Revert "boards: nrf: fix deprecated I2C properties" This reverts commit 2a4ac9a. Revert "samples: switch nrf overlays to sda-gpios, scl-gpios" This reverts commit 01bb08e. Revert "boards: nrf: switch to sda-gpios, scl-gpios" This reverts commit 17a6630. Revert "i2c: nordic: switch to phandle arrays for pinmux" This reverts commit 821c03a. Signed-off-by: Martí Bolívar <marti.bolivar@nordicsemi.no>
Go back to the -pin variants. Signed-off-by: Martí Bolívar <marti.bolivar@nordicsemi.no>
mbolivar-nordic
force-pushed
the
dt-nrf-revert-i2c
branch
2 times, most recently
from
9951857
to
50936c8
Compare
|
Getting the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #31965 and follow-on changes that depend on it.
See discussion in that PR for why; the short answer is that it's incompatible with the way the pinmux framework is evolving.