Bluetooth: Audio: Fix dead code issue in VCS

[Thalley]

The common API functions in VCS had dead code in specific
configurations, causing coverity issues. Fixed by this
commit.

Signed-off-by: Emil Gydesen emil.gydesen@nordicsemi.no

Fixes #35131
Fixes #35129
Fixes #35128
Fixes #35125
Fixes #35124
Fixes #35123
Fixes #35122
Fixes #35121
Fixes #35120
Fixes #35132

[joerchan]

Woah, 10 for 1. What a deal.

[Thalley]

Woah, 10 for 1. What a deal.

That's the way it is when code is basically copy-pasted :D I briefly considered a commit for each, but with such a small change I think it made sense to group them :)

[joerchan]

@Thalley Are you sure you aren't just trading one coverity warning for another now?

If the issue is that coverity sees that the return cannot be reached due to the ifdefs, wouldn't it just now say instead that the assign to -ENOTSUP would be always overwritten?

I'm thinking it might have been better to just close these is invalid/intentional.

Maybe using IS_ENABLED instead of ifdef would have improved it.

[Thalley]

@Thalley Are you sure you aren't just trading one coverity warning for another now?

If the issue is that coverity sees that the return cannot be reached due to the ifdefs, wouldn't it just now say instead that the assign to -ENOTSUP would be always overwritten?

I'm thinking it might have been better to just close these is invalid/intentional.

Maybe using IS_ENABLED instead of ifdef would have improved it.

@joerchan
Damn, I think you are right.
The bt_vcs_client calls can easily be guarded by a IS_ENABLED instead, but the server code blocks expects the vcs_inst struct to be declared, which it wouldn't be, so it requires a bit more to be able to use IS_ENABLED for the server.

We might need to just close these as invalid.

[joerchan]

Ok, then I think closing the issue without any changes is the best, coverity does not have the overview of the feature defines, so it cannot see that the code is only dead under certain circumstances.

[Thalley]

@joerchan I've tried another design that should work and not cause coverity issues.