Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

canbus: isotp: remove unused work queue #35558

Merged

Conversation

henrikbrixandersen
Copy link
Member

Remove unused local work queue.

Fixes #34862

Signed-off-by: Henrik Brix Andersen henrik@brixandersen.dk

Remove unused local work queue.

Fixes zephyrproject-rtos#34862

Signed-off-by: Henrik Brix Andersen <henrik@brixandersen.dk>
Copy link
Member

@martinjaeger martinjaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Can be re-implemented once it's actually used.

Copy link
Member

@alexanderwachter alexanderwachter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! There is a PR missing that changes to use the dedicated workq. ATM it would not pass the testcases due to some race conditions in the test. Agree with @martinjaeger to re-add it later

@galak galak merged commit 374629a into zephyrproject-rtos:main May 22, 2021
@henrikbrixandersen henrikbrixandersen deleted the canbus_isotp_no_local_workq branch May 22, 2021 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CAN ISO-TP implementation not using local work queue
4 participants