drivers: serial: nrfx_uarte: Fix race condition in async isr #36464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordic-krch
added
bug
nordic-krch
changed the title
RXTO event is generated always after ENDRX and driver relies on assumption that ENDRX event is handled before RXTO. However, when interrupt is preempted after ENDRX check returned false and RXTO event is already set handling order would be swapped. Added addtional check to handle RXTO event only if ENDRX is not set. If ENDRX is set, it means that it is not yet handled. RXTO event is not cleared and interrupt will be triggered again and ENDRX event will be handled first. Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no>
nordic-krch
force-pushed
the
fix/nrfx_uarte_endrx_race
branch
from
d7a699b
to
94d1ee2
Compare
Mierunski
approved these changes
Jun 23, 2021
dcpleung
approved these changes
Jun 28, 2021
anangl
approved these changes
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RXTO event is generated always after ENDRX and driver relies
on assumption that ENDRX event is handled before RXTO. However,
when interrupt is preempted after ENDRX check returned false
and RXTO event is already set handling order would be swapped.
Added addtional check to handle RXTO event only if ENDRX is not
set. If ENDRX is set, it means that it is not yet handled. RXTO
event is not cleared and interrupt will be triggered again and
ENDRX event will be handled first.
Signed-off-by: Krzysztof Chruscinski krzysztof.chruscinski@nordicsemi.no