Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

templates: Create GitHub nomination template #38392

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

keith-zephyr
Copy link
Contributor

Create a template for nominating GitHub users for an elevated
permission levels.

Signed-off-by: Keith Short keithshort@google.com

@mbolivar-nordic
Copy link
Contributor

** anasnashif ** approved these changes yesterday

@nashif care to try again?

Copy link
Contributor

@mbolivar-nordic mbolivar-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on; I've recorded the next steps above.

@keith-zephyr
Copy link
Contributor Author

** anasnashif ** approved these changes yesterday

@nashif care to try again?

I believe this was Anas testing out some permission levels and doesn't represent an actual vote.

@mbolivar-nordic mbolivar-nordic added the Process Tracked by the process WG label Sep 15, 2021
@mbolivar-nordic mbolivar-nordic added this to In progress in Process Sep 15, 2021
@mbolivar-nordic
Copy link
Contributor

Process WG: wait for update and continue review here

@mbolivar-nordic
Copy link
Contributor

mbolivar-nordic commented Sep 22, 2021

Process WG follow up actions:

@nashif
Copy link
Member

nashif commented Sep 24, 2021

@keith-packard can you fix the issues and move from draft?

@keith-zephyr
Copy link
Contributor Author

@keith-packard can you fix the issues and move from draft?

I was OOO the end of last week. I'll get these issues cleaned up by tomorrow (Sept. 27)

@keith-zephyr keith-zephyr moved this from In progress to Done in Process Sep 27, 2021
@keith-zephyr keith-zephyr marked this pull request as ready for review September 27, 2021 22:39
@keith-zephyr keith-zephyr moved this from Done to In progress in Process Sep 27, 2021
Copy link
Contributor

@mbolivar-nordic mbolivar-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A couple of nitpicks and one question.

.github/ISSUE_TEMPLATE/nomination.md Outdated Show resolved Hide resolved
doc/development_process/project_roles.rst Outdated Show resolved Hide resolved
doc/development_process/project_roles.rst Show resolved Hide resolved
@mbolivar-nordic
Copy link
Contributor

Process WG:

  • Get agreement on this PR
  • @nashif: should bring it up at the TSC, @mbolivar-nordic to discuss the changes to permissions
  • Escalated to TSC after that point

@mbolivar-nordic mbolivar-nordic added DNM This PR should not be merged (Do Not Merge) TSC Topics that need TSC discussion labels Sep 29, 2021
@mbolivar-nordic
Copy link
Contributor

Added DNM and TSC per discussion in the process WG (see above).

@mbolivar-nordic mbolivar-nordic moved this from In progress to Awaiting TSC decision in Process Oct 6, 2021
Create a template for nominating GitHub users for an elevated
permission levels. Update the TSC Project Roles page to reference the
nomination template and add clarity to the GitHub permissions allowed at
each level.

Signed-off-by: Keith Short <keithshort@google.com>
@nashif nashif removed the DNM This PR should not be merged (Do Not Merge) label Oct 13, 2021
@nashif nashif merged commit fbf39f2 into zephyrproject-rtos:main Oct 13, 2021
@mbolivar-nordic mbolivar-nordic moved this from Awaiting TSC decision to Done in Process Oct 13, 2021
@keith-zephyr keith-zephyr deleted the nomination-template branch October 26, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Continuous Integration area: Documentation Process Tracked by the process WG TSC Topics that need TSC discussion
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

7 participants