Fix native_posix build on Debian #38903

yperess · 2021-09-28T05:04:50Z

Debian (by default) enables PIE/PIC and the flag to override it doesn't
use the 'f' prefix. This is fixed by also adding -no-pie and -no-pic
to the zephyr_cc_options.

Issue #35244

Signed-off-by: Yuval Peress peress@google.com

yperess · 2021-09-28T05:05:21Z

@yashi This fixes the issue on my device. Could you give it a try?

yperess · 2021-09-28T05:32:39Z

Set as draft, it seems to break other builds. I'll keep playing around with these flags.

tejlmand · 2021-09-28T11:50:03Z

it's most likely related to this binutils commit:
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=fa6ecf940581b4be26165351bb0473427d31c7d8

but note, this is only a linker warning, but because all warnings are treated as errors per default when using twister the end result is an error.

yperess · 2021-09-30T19:11:36Z

I also considered putting this under cmake/compiler/**/*.cmake but it seemed like it would be a lot of repeated commands. I'm open to trying it.

yashi · 2021-10-01T01:34:41Z

@yashi This fixes the issue on my device. Could you give it a try?

I've missed this somehow. I'll find time to test it today. meanwhile,

The GCC compiler option for no-pie/no-pic doesn't include the 'f' prefix.

Is this really true? I see -fno-pie, -fno-pic, and -no-pie in the GCC repo. but no mention of -no-pic.

GCC info has -no-pie in the section "3.15 Options for Linking", but not -no-pic. (emphasis mine)

yperess · 2021-10-01T06:03:40Z

@yashi This fixes the issue on my device. Could you give it a try?

I've missed this somehow. I'll find time to test it today. meanwhile,

The GCC compiler option for no-pie/no-pic doesn't include the 'f' prefix.

Is this really true? I see -fno-pie, -fno-pic, and -no-pie in the GCC repo. but no mention of -no-pic.

GCC info has -no-pie in the section "3.15 Options for Linking", but not -no-pic. (emphasis mine)

You're right about -no-pic it looks like it's an architecture specific and should be prefixed with m, so -mno-pic. I'm seeing a reference to -fno-pic but only in the documentation under -miamcu. I'm not seeing anything about -fno-pie.

Easiest reference I've been looking at is at https://man7.org/linux/man-pages/man1/gcc.1.html, do you have a better one?

yashi · 2021-10-01T09:16:34Z

How about something like this:

diff --git a/cmake/linker/ld/target_baremetal.cmake b/cmake/linker/ld/target_baremetal.cmake
index 36ec3c14d8..76965ed81b 100644
--- a/cmake/linker/ld/target_baremetal.cmake
+++ b/cmake/linker/ld/target_baremetal.cmake
@@ -8,7 +8,6 @@ macro(toolchain_ld_baremetal)
   zephyr_ld_options(
     -nostdlib
     -static
-    -no-pie
     ${LINKERFLAGPREFIX},-X
     ${LINKERFLAGPREFIX},-N
   )
diff --git a/cmake/linker/ld/target_base.cmake b/cmake/linker/ld/target_base.cmake
index 0eee30ea85..1fec5ca96f 100644
--- a/cmake/linker/ld/target_base.cmake
+++ b/cmake/linker/ld/target_base.cmake
@@ -11,6 +11,7 @@ macro(toolchain_ld_base)
   # TOOLCHAIN_LD_FLAGS comes from compiler/gcc/target.cmake
   # LINKERFLAGPREFIX comes from linker/ld/target.cmake
   zephyr_ld_options(
+    -no-pie
     ${TOOLCHAIN_LD_FLAGS}
   )

We unconditionally set -fno-pie for "code generation" in the root CMakeLists.txt, why not set -no-pie for "linking"? zephyr_ld_options() checks to see the option is supported by the selected compiler. Unconditionally setting no-pie states that we want the final binary to be non position independent executable in all cases.

yperess · 2021-10-01T17:49:27Z

How about something like this:

diff --git a/cmake/linker/ld/target_baremetal.cmake b/cmake/linker/ld/target_baremetal.cmake
index 36ec3c14d8..76965ed81b 100644
--- a/cmake/linker/ld/target_baremetal.cmake
+++ b/cmake/linker/ld/target_baremetal.cmake
@@ -8,7 +8,6 @@ macro(toolchain_ld_baremetal)
   zephyr_ld_options(
     -nostdlib
     -static
-    -no-pie
     ${LINKERFLAGPREFIX},-X
     ${LINKERFLAGPREFIX},-N
   )
diff --git a/cmake/linker/ld/target_base.cmake b/cmake/linker/ld/target_base.cmake
index 0eee30ea85..1fec5ca96f 100644
--- a/cmake/linker/ld/target_base.cmake
+++ b/cmake/linker/ld/target_base.cmake
@@ -11,6 +11,7 @@ macro(toolchain_ld_base)
   # TOOLCHAIN_LD_FLAGS comes from compiler/gcc/target.cmake
   # LINKERFLAGPREFIX comes from linker/ld/target.cmake
   zephyr_ld_options(
+    -no-pie
     ${TOOLCHAIN_LD_FLAGS}
   )

We unconditionally set -fno-pie for "code generation" in the root CMakeLists.txt, why not set -no-pie for "linking"? zephyr_ld_options() checks to see the option is supported by the selected compiler. Unconditionally setting no-pie states that we want the final binary to be non position independent executable in all cases.

That works on my machine, update the PR and we'll see what the CI thinks :)

yashi · 2021-10-02T10:07:17Z

CMakeLists.txt

@@ -302,7 +302,6 @@ zephyr_compile_options($<$<COMPILE_LANGUAGE:CXX>:$<TARGET_PROPERTY:compiler-cpp,
 include(cmake/extra_flags.cmake)

 zephyr_cc_option(-fno-asynchronous-unwind-tables)
-zephyr_cc_option(-fno-pie)


Why do you want to remove this?

Isn't it now added in ld/target_base.cmake anyway? Did I misunderstand how that .cmake file gets included?

yashi

Update -fno-pie to only be added when relevant. This fixes native_posix builds on Debian hosts.

This doesn't describe what the error is nor why we add this change. A few points we should make in the commit log are:

Debian and other Linux distributions have ld with --warn-textrel as default.
The option generates a warning when linking on x86.
The warning make scripts/twister fail because we treat all warnings as error.
The warning is issued when no PIE objects are linked against PIE library.
PIE (Position Independent Executable) or not can be seen with the following command.
When you want to generate non PIE, link with -no-pie.

Non PIE

$ readelf -l build/zephyr/zephyr.elf | grep 'Elf file type is'
Elf file type is EXEC (Executable file)

PIE

$ readelf -l /lib/x86_64-linux-gnu/libc.so.6 | grep 'Elf file type is'
Elf file type is DYN (Shared object file)

yperess · 2021-10-02T16:13:42Z

Update -fno-pie to only be added when relevant. This fixes native_posix builds on Debian hosts.

This doesn't describe what the error is nor why we add this change. A few points we should make in the commit log are:

Debian and other Linux distributions have ld with --warn-textrel as default.

The option generates a warning when linking on x86.

The warning make scripts/twister fail because we treat all warnings as error.

The warning is issued when no PIE objects are linked against PIE library.

PIE (Position Independent Executable) or not can be seen with the following command.

When you want to generate non PIE, link with -no-pie.

Non PIE
$ readelf -l build/zephyr/zephyr.elf | grep 'Elf file type is'
Elf file type is EXEC (Executable file)
PIE
$ readelf -l /lib/x86_64-linux-gnu/libc.so.6 | grep 'Elf file type is'
Elf file type is DYN (Shared object file)

Done, I added this content. Sorry, I assumed all the rest of the info could be found by following the issue link.

Update -fno-pie to only be added when relevant. This fixes native_posix builds on Debian hosts. * Debian and other Linux distributions have ld with --warn-textrel as default. * The option generates a warning when linking on x86. * The warning make scripts/twister fail because we treat all warnings as error. * The warning is issued when no PIE objects are linked against PIE library. * PIE (Position Independent Executable) or not can be seen with the following command. * When you want to generate non PIE, link with `-no-pie.` Non PIE $ readelf -l build/zephyr/zephyr.elf | grep 'Elf file type is' Elf file type is EXEC (Executable file) PIE $ readelf -l /lib/x86_64-linux-gnu/libc.so.6 | \ grep 'Elf file type is' Elf file type is DYN (Shared object file) Issue zephyrproject-rtos#35244 Signed-off-by: Yuval Peress <peress@google.com>

tejlmand

lgtm

See also zephyrproject-rtos#38903 This is required when building tests for native_posix on ubuntu 22.04 using clang-14 from the normal deb repository. Signed-off-by: Christian Taedcke <christian.taedcke@lemonbeat.com>

See also zephyrproject-rtos#38903 This is required when building tests for native_posix on ubuntu 22.04 using clang-14 from the normal deb repository. Signed-off-by: Christian Taedcke <christian.taedcke@lemonbeat.com> (cherry picked from commit 017fdc0a8769ab15172ad11e951ed9be1184d631)

See also #38903 This is required when building tests for native_posix on ubuntu 22.04 using clang-14 from the normal deb repository. Signed-off-by: Christian Taedcke <christian.taedcke@lemonbeat.com>

See also zephyrproject-rtos/zephyr#38903 This is required when building tests for native_posix on ubuntu 22.04 using clang-14 from the normal deb repository. (cherry picked from commit 1fde62e) Original-Signed-off-by: Christian Taedcke <christian.taedcke@lemonbeat.com> GitOrigin-RevId: 1fde62e Change-Id: I76cfb2bbd71df1ffb137b681b648320081f9f046 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/4047582 Commit-Queue: Fabio Baltieri <fabiobaltieri@google.com> Reviewed-by: Yuval Peress <peress@google.com> Tested-by: CopyBot Service Account <copybot.service@gmail.com> Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com> Reviewed-by: Keith Short <keithshort@chromium.org> Tested-by: Yuval Peress <peress@google.com> Tested-by: Fabio Baltieri <fabiobaltieri@google.com> Tested-by: Keith Short <keithshort@chromium.org>

See also zephyrproject-rtos/zephyr#38903 This is required when building tests for native_posix on ubuntu 22.04 using clang-14 from the normal deb repository. Signed-off-by: Christian Taedcke <christian.taedcke@lemonbeat.com>

yperess requested review from nashif and tejlmand as code owners September 28, 2021 05:04

yperess force-pushed the pie branch from 8134ee7 to daf4617 Compare September 28, 2021 05:13

yperess marked this pull request as draft September 28, 2021 05:32

yperess force-pushed the pie branch 2 times, most recently from 70ecd1f to 2057b0b Compare September 30, 2021 02:53

yperess marked this pull request as ready for review September 30, 2021 19:10

zephyrbot added the area: Build System label Oct 1, 2021

zephyrbot assigned tejlmand Oct 1, 2021

yperess force-pushed the pie branch from 2057b0b to a1363b4 Compare October 1, 2021 17:49

jackrosenthal approved these changes Oct 1, 2021

View reviewed changes

yashi self-requested a review October 2, 2021 10:05

yashi reviewed Oct 2, 2021

View reviewed changes

yperess force-pushed the pie branch from a1363b4 to dd805fe Compare October 2, 2021 16:16

yashi approved these changes Oct 2, 2021

View reviewed changes

yperess force-pushed the pie branch from dd805fe to f03a7a2 Compare October 5, 2021 03:27

tejlmand approved these changes Oct 5, 2021

View reviewed changes

nashif merged commit a81f8af into zephyrproject-rtos:main Oct 5, 2021

tejlmand mentioned this pull request Dec 14, 2021

Toolchain/armlink configure linker script fixup #41144

Merged

chrta mentioned this pull request Nov 2, 2022

cmake: linker: lld: add missing -no-pie flag #51900

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix native_posix build on Debian #38903

Fix native_posix build on Debian #38903

yperess commented Sep 28, 2021

yperess commented Sep 28, 2021

yperess commented Sep 28, 2021

tejlmand commented Sep 28, 2021

yperess commented Sep 30, 2021

yashi commented Oct 1, 2021

yperess commented Oct 1, 2021

yashi commented Oct 1, 2021

yperess commented Oct 1, 2021

yashi Oct 2, 2021

yperess Oct 2, 2021

yashi left a comment

yperess commented Oct 2, 2021

tejlmand left a comment

Fix native_posix build on Debian #38903

Fix native_posix build on Debian #38903

Conversation

yperess commented Sep 28, 2021

yperess commented Sep 28, 2021

yperess commented Sep 28, 2021

tejlmand commented Sep 28, 2021

yperess commented Sep 30, 2021

yashi commented Oct 1, 2021

yperess commented Oct 1, 2021

yashi commented Oct 1, 2021

yperess commented Oct 1, 2021

yashi Oct 2, 2021

Choose a reason for hiding this comment

yperess Oct 2, 2021

Choose a reason for hiding this comment

yashi left a comment

Choose a reason for hiding this comment

yperess commented Oct 2, 2021

tejlmand left a comment

Choose a reason for hiding this comment