drivers: spi: mark old spi_cs_control fields deprecated

[bbilas]

Since gpio_dt_spec is finally available in the spi_cs_control struct, mark the old fields deprecated in order to use the gpio_dt_spec struct.

Depends on #37498 and #39341

Signed-off-by: Jordan Yates jordan.yates@data61.csiro.au
Co-authored-by: Jordan Yates jordan.yates@data61.csiro.au
Signed-off-by: Bartosz Bilas bartosz.bilas@hotmail.com
Co-authored-by: Bartosz Bilas bartosz.bilas@hotmail.com

[henrikbrixandersen]

This is a stable API change.

[carlescufi]

This is a stable API change.

I am not sure I get this. We are deprecating structures, how is that a stable API change? By definition we call a Stable API change one that does not follow the standard deprecation process.

[henrikbrixandersen]

I am not sure I get this. We are deprecating structures, how is that a stable API change? By definition we call a Stable API change one that does not follow the standard deprecation process.

Exactly my point. This change needs to follow the process for changing a stable API as described here: https://docs.zephyrproject.org/latest/reference/api/api_lifecycle.html#introducing-incompatible-changes

[henrikbrixandersen]

Blocking pending the process for changing a stable API has been met.

[carlescufi]

I am not sure I get this. We are deprecating structures, how is that a stable API change? By definition we call a Stable API change one that does not follow the standard deprecation process.

Exactly my point. This change needs to follow the process for changing a stable API as described here: https://docs.zephyrproject.org/latest/reference/api/api_lifecycle.html#introducing-incompatible-changes

@henrikbrixandersen maybe there is some confusion here :)
The section you linked to was introduced for the cases where one does not want to use deprecation. If you use deprecation then there's no need to follow that guide, which was designed for the cases that require skipping deprecation due to complexity.

[carlescufi]

Apologies for closing this, I clicked on it by mistake.

[henrikbrixandersen]

@henrikbrixandersen maybe there is some confusion here :) The section you linked to was introduced for the cases where one does not want to use deprecation. If you use deprecation then there's no need to follow that guide, which was designed for the cases that require skipping deprecation due to complexity.

Sorry, meant to link to https://docs.zephyrproject.org/latest/reference/api/api_lifecycle.html#deprecated.

[bbilas]

FYI: that's not a ready MR since there is a couple of places where the old spi_cs_control members are being used but I'm periodically rebasing it and checking the buildkite results. I think DNM label should be set here...

[bbilas]

cc @carlescufi @henrikbrixandersen issue #44956 created

[bbilas]

In the meantime, someone has committed a new code where the deprecated members are being used... I will try to fix that soon.

[bbilas]

@carlescufi @henrikbrixandersen hotfix #44968 ;)