drivers: can: socketCAN: move code from drivers to its own file #41847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderwachter
requested review from
karstenkoenig,
pfalcon,
rlubos and
tbursztyka
as code owners
github-actions
bot
added
area: Samples
alexanderwachter
force-pushed
the
can/socketCAN/removeCodeFromDrivers
branch
from
7b60e58
to
3e4c617
Compare
jukkar
requested changes
Jan 16, 2022
alexanderwachter
force-pushed
the
can/socketCAN/removeCodeFromDrivers
branch
from
7c68a2c
to
4498ad6
Compare
|
Doc CI fail is unrelated. |
henrikbrixandersen
requested changes
Jan 16, 2022
alexanderwachter
force-pushed
the
can/socketCAN/removeCodeFromDrivers
branch
from
4498ad6
to
0c0d163
Compare
henrikbrixandersen
requested changes
Jan 16, 2022
zephyrbot
requested review from
ABOSTM
and removed request for
jukkar,
tbursztyka,
karstenkoenig and
rlubos
henrikbrixandersen
previously approved these changes
Feb 3, 2022
@alexanderwachter Any progress on this? Any more information on the errors, you are seeing? Are they also present on |
@alexanderwachter Please provide further details on the issues you are seeing? |
alexanderwachter
force-pushed
the
can/socketCAN/removeCodeFromDrivers
branch
from
051a0aa
to
38888b7
Compare
|
@henrikbrixandersen it was a stack overflow, caused by log immediate and a -115. I used the wrong symbol for the loopback Kconfig (forgot the CONFIG_ prefix). |
alexanderwachter
force-pushed
the
can/socketCAN/removeCodeFromDrivers
branch
from
38888b7
to
d2be9e8
Compare
jukkar
previously approved these changes
Apr 7, 2022
henrikbrixandersen
requested changes
Apr 7, 2022
| @@ -176,6 +180,10 @@ static int setup_socket(void) | |||
| return -ENOENT; | |||
| } | |||
|
|
|||
| #ifdef CONFIG_SAMPLE_SOCKET_CAN_LOOPBACK_MODE | |||
| can_set_mode(DEVICE_DT_GET(DT_CHOSEN(zephyr_canbus)), CAN_LOOPBACK_MODE); | |||
There was a problem hiding this comment.
With loopback mode, we should be able to remove the harness from samples/net/sockets/can/sample.yaml and add a console fixture for validating the sample in CI.
alexanderwachter
force-pushed
the
can/socketCAN/removeCodeFromDrivers
branch
from
d2be9e8
to
2797326
Compare
Move the code for socket instanciation from each driver to a generic driver, that makes an instance of a socketCAN net device for the chosen node. Signed-off-by: Alexander Wachter <alexander@wachter.cloud>
Add loopback mode config to the sample so that the code can be tested without an actual CAN network, but wit a single board. Signed-off-by: Alexander Wachter <alexander@wachter.cloud>
Do not log immediate in the sample, because it causes stack overflows. Signed-off-by: Alexander Wachter <alexander@wachter.cloud>
henrikbrixandersen
approved these changes
Apr 7, 2022
henrikbrixandersen
requested review from
dleach02,
jukkar and
karstenkoenig
and removed request for
dleach02
jukkar
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup the drivers from socketCAN and make its own driver that instantiates the net interface.