Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drivers: U-Blox NEO-M8 Driver implementation + Sample Project #46447

Closed
wants to merge 1 commit into from

Conversation

RodinHaker
Copy link

Added the driver for the ublox neo-m8 GNSS module.
The data fetching and settings functions can be done using the API.
A sample project has been added to show the usage of this driver.
As of right now only one message is being parsed and three settings can be done.
However, the function to write UBX messages to the module is also approachable through the API.

Signed-off-by: Rodin Haker rodinhaker@hotmail.com

Copy link
Collaborator

@galak galak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove reg:... from dts binding as its handled in i2c-device.yaml

dts/bindings/gnss/ublox,neom8.yaml Outdated Show resolved Hide resolved
@RodinHaker RodinHaker requested a review from galak June 10, 2022 22:24
Copy link
Collaborator

@ycsin ycsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-format should be ran against these files so that they are compliant with the Zephyr's standard. I think you will also need to propose a generic gnss interface

see #46452, #30564

include/drivers/gnss/ublox_neo_m8.h Outdated Show resolved Hide resolved
include/drivers/gnss/ublox_neo_m8.h Outdated Show resolved Hide resolved
include/drivers/gnss/ublox_neo_m8.h Outdated Show resolved Hide resolved
include/drivers/gnss/ublox_neo_m8.h Outdated Show resolved Hide resolved
samples/drivers/neo_m8/boards/stm32l1_disco.overlay Outdated Show resolved Hide resolved
include/drivers/gnss/ublox_neo_m8.h Outdated Show resolved Hide resolved
include/drivers/gnss/ublox_neo_m8_defines.h Outdated Show resolved Hide resolved
@RodinHaker
Copy link
Author

clang-format should be ran against these files so that they are compliant with the Zephyr's standard. I think you will also need to propose a generic gnss interface

see #46452, #30564

Should I wait for #46660 to complete and adjust my driver accordingly?

@sslupsky
Copy link
Contributor

Had a quick look at the UBX processing and offer the following feedback. I did something similar when I created a driver for the ublox SAM M8. As I recall, I found that there are delays in the response from the device. Moreover, I seem to recall it is possible in some circumstances that you may not actually get a response. This became problematic for power management purposes because you get stuck waiting for a response in neom8_send_ubx(). The way I solved the issue was to create another task that deals with the response and then notifies the application using a call back mechanism when a response is received. That way, I could wait on a semaphore which would allow the system to idle and sleep while waiting for a response.

@ycsin
Copy link
Collaborator

ycsin commented Jun 20, 2022

clang-format should be ran against these files so that they are compliant with the Zephyr's standard. I think you will also need to propose a generic gnss interface
see #46452, #30564

Should I wait for #46660 to complete and adjust my driver accordingly?

I'd suggest you to wait, and also help shape that API proposal if possible

@RodinHaker RodinHaker changed the base branch from backport-41247-to-v2.7-branch to main June 24, 2022 12:13
Added ublox neo-m8 driver with data reading/parsing and settings functions.

Signed-off-by: Rodin Haker <rodinhaker@hotmail.com>
@sslupsky
Copy link
Contributor

sslupsky commented Jul 6, 2022

@RodinHaker I posted my out-of-tree zephyr things here: https://github.com/sslupsky/zephyr-out-of-tree

There is a driver for the ublox_m8 there if you want to have a look and compare approach.

@github-actions
Copy link

github-actions bot commented Sep 5, 2022

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Sep 5, 2022
@github-actions github-actions bot closed this Sep 20, 2022
mayankmahajan-nxp added a commit to mayankmahajan-nxp/zephyr that referenced this pull request Feb 2, 2024
MODEM_UBX: Adds Support for UBX Messages in Modem Subsystem

GNSS API Supported:
	 get_supported_systems, get_enabled_systems, set_enabled_systems

Boards Tested: MIMXRT1062_FMURT6

Note: Partial support for UBX Messages is provided as of now.

Referred code from zephyrproject-rtos#46447

Signed-off-by: Sumit Batra <sumit.batra@nxp.com>
Signed-off-by: Mayank Mahajan <mayankmahajan.x@nxp.com>
mayankmahajan-nxp added a commit to mayankmahajan-nxp/zephyr that referenced this pull request Feb 2, 2024
MODEM_UBX: Adds Support for UBX Messages in Modem Subsystem

GNSS API Supported:
	 get_supported_systems, get_enabled_systems, set_enabled_systems

Boards Tested: MIMXRT1062_FMURT6

Note: Partial support for UBX Messages is provided as of now.

Referred code from zephyrproject-rtos#46447

Signed-off-by: Sumit Batra <sumit.batra@nxp.com>
Signed-off-by: Mayank Mahajan <mayankmahajan.x@nxp.com>
mayankmahajan-nxp added a commit to mayankmahajan-nxp/zephyr that referenced this pull request Feb 5, 2024
MODEM_UBX: Adds Support for UBX Messages in Modem Subsystem.

GNSS API Supported:
	get_supported_systems, get_enabled_systems, set_enabled_systems,
	u_blox_m10_set_navigation_mode, u_blox_m10_get_navigation_mode.

Boards Tested: MIMXRT1062_FMURT6.

Note: Partial support for UBX Messages is provided as of now.

Referred code from zephyrproject-rtos#46447

Signed-off-by: Sumit Batra <sumit.batra@nxp.com>
Signed-off-by: Mayank Mahajan <mayankmahajan.x@nxp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants