drivers: spi: STM32 half-duplex master SPI support #46803

jefflongo · 2022-06-22T17:25:53Z

Adds support for the SPI_HALF_DUPLEX flag to the STM32 SPI driver for an STM32 SPI master to use unidirectional or bidirection 3-wire SPI. Tested using an HMC7043.

FRASTM · 2022-06-23T12:04:43Z

drivers/spi/spi_ll_stm32.c

 */
 static int spi_stm32_shift_frames(SPI_TypeDef *spi, struct spi_stm32_data *data)
 {
 	uint16_t operation = data->ctx.config->operation;

 	if (SPI_OP_MODE_GET(operation) == SPI_OP_MODE_MASTER) {
-		spi_stm32_shift_m(spi, data);
+		if (operation & SPI_HALF_DUPLEX) {
+			spi_stm32_shift_m_half(spi, data);


what about a bool half_duplex parameter in the spi_stm32_shift_m function ?
spi_stm32_shift_m(SPI_TypeDef *spi, struct spi_stm32_data *data, bool half_duplex)

I wrote it the way I did to avoid making spi_stm32_shift_m have a bunch of cases that do different things, but if that style is better then I'm not opposed to changing it.

Reusing spi_stm32_shift_m would indeed be more memory efficient.
Can you take this request into account ?

FRASTM · 2022-06-29T09:08:45Z

drivers/spi/spi_ll_stm32.c

+/* Shift a SPI frame as half-duplex master. */
+static void spi_stm32_shift_m_half(SPI_TypeDef *spi, struct spi_stm32_data* data) {
+#if defined(CONFIG_SOC_SERIES_STM32MP1X) || defined(CONFIG_SOC_SERIES_STM32H7X) ||                 \
+	defined(CONFIG_SOC_SERIES_STM32U5X)


with line break:

#if defined(CONFIG_SOC_SERIES_STM32MP1X) || \ defined(CONFIG_SOC_SERIES_STM32H7X) || \ defined(CONFIG_SOC_SERIES_STM32U5X)

Please use "st,stm32h7-spi", cf #46852 which was merged recently

Question about the formatting - is there a particular clang-format version that's needed, because the zephyr .clang-format file does not seem to agree with a lot of the formatting in this file.

We don't run clang-format on all files.
And for now we're still discussing about the rules we want to apply. See #cleanup channel on discord.

erwango · 2022-07-05T15:47:50Z

drivers/spi/spi_ll_stm32.c

-	if (LL_SPI_GetMode(spi) == LL_SPI_MODE_MASTER) {
-		LL_SPI_StartMasterTransfer(spi);
-		while (!LL_SPI_IsActiveMasterTransfer(spi)) {
-			/* NOP */
+		if (LL_SPI_GetMode(spi) == LL_SPI_MODE_MASTER) {
+			LL_SPI_StartMasterTransfer(spi);
+			while (!LL_SPI_IsActiveMasterTransfer(spi)) {
+				/* NOP */
+			}
 		}


Can you factorize half_duplex and full_duplex case a bit more ?
This exact piece of code seems to be exact same on full_duplex

erwango · 2022-07-05T15:49:29Z

@jefflongo Once you're done with code changes, can you have a look to these slides on how to format the PR and commit message: https://static.sched.com/hosted_files/zephyr2022/a3/HOWTO_Get_Your_Zephyr_Patches_Merged_ZDS_2022.pdf ?
Thanks

Cherish-Gww · 2022-08-30T07:06:55Z

drivers/spi/spi_ll_stm32.c

+					/* NOP */
+				}
+			}
+			spi_context_update_tx(&data->ctx, 1, 1);


I think spi_context_update_tx need put to previous line.
because when spi transmit sucessed then update spi context.

And I think there is no need split half_duplex code and funll_fuplex code.
only add if ( half_duplex ) return; after spi_context_update_tx.

Cherish-Gww · 2022-08-30T07:07:29Z

drivers/spi/spi_ll_stm32.c

+					/* NOP */
+				}
+			}
+			spi_context_update_tx(&data->ctx, 2, 1);


same as 8bit process

Cherish-Gww · 2022-08-30T07:12:45Z

drivers/spi/spi_ll_stm32.c

+				uint8_t rx_frame = LL_SPI_ReceiveData8(spi);
+				UNALIGNED_PUT(rx_frame, (uint8_t *)data->ctx.rx_buf);
+			}
+			spi_context_update_rx(&data->ctx, 1, 1);


same as 8bit tx process

Cherish-Gww · 2022-08-30T07:12:54Z

drivers/spi/spi_ll_stm32.c

+				uint16_t rx_frame = LL_SPI_ReceiveData16(spi);
+				UNALIGNED_PUT(rx_frame, (uint16_t *)data->ctx.rx_buf);
+			}
+			spi_context_update_rx(&data->ctx, 2, 1);


same as 8bit tx process

erwango · 2022-08-31T08:53:33Z

@jefflongo Any plans to continue upstream process for this driver ?

Cherish-Gww · 2022-09-07T07:22:05Z

drivers/spi/spi_ll_stm32.c

+			if (spi_context_tx_buf_on(&data->ctx)) {
+				uint8_t tx_frame = UNALIGNED_GET((uint8_t *)(data->ctx.tx_buf));
+				LL_SPI_TransmitData8(spi, tx_frame);
+				while (!ll_func_tx_is_empty(spi)) {


In spi interrupt mode, invoke spi_stm32_shift_m too.

jefflongo · 2022-09-08T03:17:07Z

@jefflongo Any plans to continue upstream process for this driver ?

We ended up switching to 4-wire SPI in the project I needed this for. I'm pretty busy at the moment so I probably won't get to updating this for awhile. If I catch a break I will work on updating this PR.

github-actions · 2022-11-08T00:30:06Z

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

jefflongo requested a review from tbursztyka as a code owner June 22, 2022 17:25

zephyrbot added area: SPI SPI bus platform: STM32 ST Micro STM32 labels Jun 22, 2022

zephyrbot requested review from ABOSTM, erwango, FRASTM, GeorgeCGV and gmarull June 22, 2022 17:26

zephyrbot assigned erwango Jun 22, 2022

FRASTM reviewed Jun 23, 2022

View reviewed changes

erwango mentioned this pull request Jun 23, 2022

dts: stm32: Add a st,stm32h7-spi compatible to enhance driver portability #46852

Merged

FRASTM reviewed Jun 29, 2022

View reviewed changes

jefflongo force-pushed the stm32-3wire-spi branch 3 times, most recently from ee21289 to 2d1c649 Compare July 5, 2022 15:46

erwango reviewed Jul 5, 2022

View reviewed changes

add half-duplex master spi support to stm32

7c22e86

jefflongo force-pushed the stm32-3wire-spi branch from 2d1c649 to 7c22e86 Compare July 5, 2022 15:52

erwango mentioned this pull request Aug 24, 2022

STM32 SPI Set transfer direction is fixed #49446

Open

Cherish-Gww reviewed Aug 30, 2022

View reviewed changes

Cherish-Gww reviewed Sep 7, 2022

View reviewed changes

github-actions bot added the Stale label Nov 8, 2022

github-actions bot closed this Nov 22, 2022

erwango mentioned this pull request May 17, 2023

SPI: Stm32 3-wire (half-duplex) support #57993

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

drivers: spi: STM32 half-duplex master SPI support #46803

drivers: spi: STM32 half-duplex master SPI support #46803

jefflongo commented Jun 22, 2022

FRASTM Jun 23, 2022 •

edited

Loading

jefflongo Jun 23, 2022

erwango Jun 29, 2022

FRASTM Jun 29, 2022

erwango Jul 5, 2022

jefflongo Jul 5, 2022

erwango Jul 5, 2022

erwango Jul 5, 2022

erwango commented Jul 5, 2022

Cherish-Gww Aug 30, 2022

Cherish-Gww Aug 30, 2022

Cherish-Gww Aug 30, 2022

Cherish-Gww Aug 30, 2022

Cherish-Gww Aug 30, 2022

erwango commented Aug 31, 2022

Cherish-Gww Sep 7, 2022

jefflongo commented Sep 8, 2022

github-actions bot commented Nov 8, 2022

drivers: spi: STM32 half-duplex master SPI support #46803

drivers: spi: STM32 half-duplex master SPI support #46803

Conversation

jefflongo commented Jun 22, 2022

FRASTM Jun 23, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

erwango commented Jul 5, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

erwango commented Aug 31, 2022

Choose a reason for hiding this comment

jefflongo commented Sep 8, 2022

github-actions bot commented Nov 8, 2022

FRASTM Jun 23, 2022 •

edited

Loading