Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clang-format: do not put enums in single line #47165

Merged
merged 1 commit into from Jul 1, 2022
Merged

clang-format: do not put enums in single line #47165

merged 1 commit into from Jul 1, 2022

Conversation

nashif
Copy link
Member

@nashif nashif commented Jul 1, 2022

clang-format puts short enums in one single line, making them
unreadable.

for example:

enum ztest_result {
    ZTEST_RESULT_PENDING,
    ZTEST_RESULT_PASS,
    ZTEST_RESULT_FAIL,
    ZTEST_RESULT_SKIP
};
enum ztest_result { ZTEST_RESULT_PENDING, ZTEST_RESULT_PASS, ZTEST_RESULT_FAIL, ZTEST_RESULT_SKIP };

Signed-off-by: Anas Nashif anas.nashif@intel.com

@nashif nashif requested a review from gmarull July 1, 2022 14:49
stephanosio
stephanosio approved these changes Jul 1, 2022
View reviewed changes
Copy link
Member

@stephanosio stephanosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also good for diff-ing.

stephanosio
stephanosio previously approved these changes Jul 1, 2022
View reviewed changes
gmarull
gmarull reviewed Jul 1, 2022
View reviewed changes
.clang-format Outdated Show resolved Hide resolved
@nashif
clang-format: do not put enums in single line
c416f05 
clang-format puts short enums in one single line, making them
unreadable.

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
@nashif nashif merged commit 51f9f7c into zephyrproject-rtos:main Jul 1, 2022
@nashif nashif deleted the clang-f-enum branch July 1, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrikbrixandersen henrikbrixandersen henrikbrixandersen approved these changes

@stephanosio stephanosio stephanosio approved these changes

@gmarull gmarull gmarull approved these changes

@dkalowsk dkalowsk Awaiting requested review from dkalowsk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nashif @henrikbrixandersen @stephanosio @gmarull