Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arch: introduce config DCLS #47558

Conversation

Dat-NguyenDuy
Copy link
Contributor

@Dat-NguyenDuy Dat-NguyenDuy commented Jul 8, 2022

Some processors support Dual-redundant Core Lock-step
(DCLS) topology but the processor still can be ran in
split-lock mode (by default or changed at flash time).
So, introduce config DCLS that is enabled by default if
config CPU_HAS_DCLS is set, it should be disabled if
processor is used in split-lock mode.

Signed-off-by: Dat Nguyen Duy dat.nguyenduy@nxp.com

@zephyrbot zephyrbot added area: ARM ARM (32-bit) Architecture area: Build System area: Toolchains Toolchains labels Jul 8, 2022
@stephanosio stephanosio assigned stephanosio and unassigned tejlmand Jul 8, 2022
@Dat-NguyenDuy Dat-NguyenDuy force-pushed the make-config-dual-core-lock-step-visible-for-user branch from 06fc865 to 8e1ccdf Compare July 8, 2022 15:03
@Dat-NguyenDuy Dat-NguyenDuy changed the title arch: add config DCLS arch: introduce config DCLS Jul 8, 2022
Copy link
Member

@stephanosio stephanosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

Just some comments about the config descriptions.

arch/Kconfig Outdated Show resolved Hide resolved
arch/Kconfig Outdated Show resolved Hide resolved
@Dat-NguyenDuy Dat-NguyenDuy force-pushed the make-config-dual-core-lock-step-visible-for-user branch from 8e1ccdf to 8eb5fc5 Compare July 29, 2022 10:50
stephanosio
stephanosio previously approved these changes Jul 29, 2022
carlocaione
carlocaione previously approved these changes Jul 29, 2022
microbuilder
microbuilder previously approved these changes Jul 29, 2022
povergoing
povergoing previously approved these changes Jul 29, 2022
@Dat-NguyenDuy
Copy link
Contributor Author

Dat-NguyenDuy commented Jul 29, 2022

Some tests are failing doesn't seem to be related to this update.
Those are caused by the new update in ztest framework: 0456ddc#diff-b3ebe2ec3825c9155a2837cabcab59384340d1a2453e90005c1efe782f1e8156R266

@carlocaione
Copy link
Collaborator

Some tests are failing doesn't seem to be related to this update. Those are caused by the new update in ztest framework: 0456ddc#diff-b3ebe2ec3825c9155a2837cabcab59384340d1a2453e90005c1efe782f1e8156R266

I wonder if this is related to #48469

@Dat-NguyenDuy
Copy link
Contributor Author

I wonder if this is related to #48469

Yep, but some tests are build failed instead

@stephanosio
Copy link
Member

stephanosio commented Jul 29, 2022

Some tests are failing doesn't seem to be related to this update.

Hotfix was merged #48475; though, the root cause has more to do with #48480.

Please rebase to fix the CI failure.

@Dat-NguyenDuy Dat-NguyenDuy force-pushed the make-config-dual-core-lock-step-visible-for-user branch from 8eb5fc5 to 1f178bc Compare July 29, 2022 15:58
stephanosio
stephanosio previously approved these changes Jul 29, 2022
microbuilder
microbuilder previously approved these changes Jul 29, 2022
Some processors support Dual-redundant Core Lock-step
DCLS) topology but the processor still can be ran in
split-lock mode (by default or changed at flash time).
So, introduce config DCLS that is enabled by default if
config CPU_HAS_DCLS is set, it should be disabled if
processor is used in split-lock mode.

Signed-off-by: Dat Nguyen Duy <dat.nguyenduy@nxp.com>
@Dat-NguyenDuy Dat-NguyenDuy force-pushed the make-config-dual-core-lock-step-visible-for-user branch from 1f178bc to 562c9b6 Compare July 29, 2022 16:50
@Dat-NguyenDuy
Copy link
Contributor Author

Dat-NguyenDuy commented Jul 29, 2022

Rebased to include this fix #48477. Now the build are passing

@stephanosio stephanosio merged commit 8e55e59 into zephyrproject-rtos:main Aug 4, 2022
@Dat-NguyenDuy Dat-NguyenDuy deleted the make-config-dual-core-lock-step-visible-for-user branch June 9, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ARM ARM (32-bit) Architecture area: Build System area: Toolchains Toolchains
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants