New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dts: arm: nrf528xx_pca100xx: Increase mcuboot partition size #4765
dts: arm: nrf528xx_pca100xx: Increase mcuboot partition size #4765
Conversation
59e15a2
to
554cb65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update node names to match
dts/arm/nrf52840_pca10056.dts
Outdated
@@ -42,19 +42,19 @@ | |||
|
|||
boot_partition: partition@0 { | |||
label = "mcuboot"; | |||
reg = <0x000000000 0x00008000>; | |||
reg = <0x000000000 0x0000C000>; | |||
}; | |||
slot0_partition: partition@8000 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update node names to match partition@8000 -> partition@c000
dts/arm/nrf52840_pca10056.dts
Outdated
}; | ||
slot0_partition: partition@8000 { | ||
label = "image-0"; | ||
reg = <0x00008000 0x00006c000>; | ||
reg = <0x0000C000 0x000069000>; | ||
}; | ||
slot1_partition: partition@74000 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update names to match
dts/arm/nrf52840_pca10056.dts
Outdated
}; | ||
slot1_partition: partition@74000 { | ||
label = "image-1"; | ||
reg = <0x00074000 0x00006c000>; | ||
reg = <0x00075000 0x000069000>; | ||
}; | ||
scratch_partition: partition@e0000 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update names to match
dts/arm/nrf52_pca10040.dts
Outdated
@@ -42,15 +42,15 @@ | |||
|
|||
boot_partition: partition@0 { | |||
label = "mcuboot"; | |||
reg = <0x00000000 0x8000>; | |||
reg = <0x00000000 0xc000>; | |||
}; | |||
slot0_partition: partition@8000 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update node names to match
dts/arm/nrf52_pca10040.dts
Outdated
}; | ||
slot0_partition: partition@8000 { | ||
label = "image-0"; | ||
reg = <0x00008000 0x34000>; | ||
reg = <0x0000C000 0x32000>; | ||
}; | ||
slot1_partition: partition@3c000 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update node names to match
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One additional comment to what @galak said
}; | ||
scratch_partition: partition@e0000 { | ||
label = "image-scratch"; | ||
reg = <0x000e0000 0x0001d000>; | ||
reg = <0x000de000 0x0001e000>; | ||
}; | ||
|
||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment and partition below here need to be fixed too (unused portion starts at 0xfc000, not 0xfd000)
Boot serial recovery feature consume additional memory size so the mcuboot partition must been expanded on cost of images partitions. Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
Boot serial recovery feature consume additional memory size so the mcuboot partition must been expanded on cost of images partitions. Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
a9cdcb4
to
34be04b
Compare
Boot serial recovery feature consume additional
memory size so the mcuboot partition must been
expanded on cost of images partitions.
Signed-off-by: Andrzej Puzdrowski andrzej.puzdrowski@nordicsemi.no