Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dts: arm: nrf528xx_pca100xx: Increase mcuboot partition size #4765

Merged

Conversation

nvlsianpu
Copy link
Collaborator

Boot serial recovery feature consume additional
memory size so the mcuboot partition must been
expanded on cost of images partitions.

Signed-off-by: Andrzej Puzdrowski andrzej.puzdrowski@nordicsemi.no

@nvlsianpu nvlsianpu changed the title dts: arm: nrf52840_pca10056: Increase mcuboot partition size dts: arm: nrf528xx_pca100xx: Increase mcuboot partition size Nov 7, 2017
Copy link
Collaborator

@galak galak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update node names to match

@@ -42,19 +42,19 @@

boot_partition: partition@0 {
label = "mcuboot";
reg = <0x000000000 0x00008000>;
reg = <0x000000000 0x0000C000>;
};
slot0_partition: partition@8000 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update node names to match partition@8000 -> partition@c000

};
slot0_partition: partition@8000 {
label = "image-0";
reg = <0x00008000 0x00006c000>;
reg = <0x0000C000 0x000069000>;
};
slot1_partition: partition@74000 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update names to match

};
slot1_partition: partition@74000 {
label = "image-1";
reg = <0x00074000 0x00006c000>;
reg = <0x00075000 0x000069000>;
};
scratch_partition: partition@e0000 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update names to match

@@ -42,15 +42,15 @@

boot_partition: partition@0 {
label = "mcuboot";
reg = <0x00000000 0x8000>;
reg = <0x00000000 0xc000>;
};
slot0_partition: partition@8000 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update node names to match

};
slot0_partition: partition@8000 {
label = "image-0";
reg = <0x00008000 0x34000>;
reg = <0x0000C000 0x32000>;
};
slot1_partition: partition@3c000 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update node names to match

Copy link
Contributor

@mbolivar mbolivar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One additional comment to what @galak said

};
scratch_partition: partition@e0000 {
label = "image-scratch";
reg = <0x000e0000 0x0001d000>;
reg = <0x000de000 0x0001e000>;
};

/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment and partition below here need to be fixed too (unused portion starts at 0xfc000, not 0xfd000)

Boot serial recovery feature consume additional
memory size so the mcuboot partition must been
expanded on cost of images partitions.

Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
Boot serial recovery feature consume additional
memory size so the mcuboot partition must been
expanded on cost of images partitions.

Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
@nvlsianpu
Copy link
Collaborator Author

@mbolivar @galak updated

@nashif nashif merged commit a59350e into zephyrproject-rtos:master Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants