Bluetooth: Controller: Fix BIG Create silently fail on RTN/SDU_interval #49394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvinayak
added
bug
cvinayak
requested review from
carlescufi,
thoh-ot and
kruithofa
as code owners
Thalley
requested changes
Sep 1, 2022
cvinayak
force-pushed
the
github_big_create_param_check_fix
branch
from
72d73a1
to
9a3b3e7
Compare
cvinayak
force-pushed
the
github_big_create_param_check_fix
branch
from
9a3b3e7
to
0aefbb8
Compare
Thalley
reviewed
Sep 6, 2022
Comment on lines
257
to
267
| if (latency_packing > sdu_interval) { | ||
| ll_rx_link_release(link_cmplt); | ||
| ll_rx_link_release(link_term); | ||
|
|
||
| return BT_HCI_ERR_INVALID_PARAM; | ||
| } |
There was a problem hiding this comment.
Can you add a in-code comment about why we are releasing the link if the latency is larger than the SDU interval? I assume it's because that would be impossible to schedule?
Fix BIG Create implementation from silently failing on values of RTN and SDU_interval that lead to BIG events that cannot be acheived when using sequential or interleaved subevents by the Controller Implementation. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
cvinayak
force-pushed
the
github_big_create_param_check_fix
branch
from
0aefbb8
to
e0b4ec1
Compare
Thalley
approved these changes
Sep 6, 2022
kruithofa
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix BIG Create implementation from silently failing on
values of RTN and SDU_interval that lead to BIG events that
cannot be acheived when using sequential or interleaved
subevents by the Controller Implementation.
Fixes #46186.
Signed-off-by: Vinayak Kariappa Chettimada vich@nordicsemi.no