tests: lib: mem_alloc: migrating mem_alloc tests to new ztest API #50164
Conversation
| @@ -1,3 +1,5 @@ | |||
| CONFIG_ZTEST=y | |||
| CONFIG_ZTEST_NEW_API=y | |||
| CONFIG_NO_OPTIMIZATIONS=y | |||
There was a problem hiding this comment.
There is a big difference between disabling optimisation globally vs. only for some functions of interest.
There was a problem hiding this comment.
Agreed, was trying a few things while testing and forgot to remove them.
yerabolu
force-pushed
the
lib_mem_alloc
branch
from
d870ea8
to
396ab53
Compare
Migrating mem_alloc tests to new ztest API. Part of zephyrproject-rtos#47002 effort Signed-off-by: Spoorthy Priya Yerabolu <spoorthy.priya.yerabolu@intel.com>
yerabolu
force-pushed
the
lib_mem_alloc
branch
from
396ab53
to
4ad71f7
Compare
|
Hi, @yerabolu , all looks good for me and I verified them in some boards such as k64f, nrf52840, nsim, etc. It works well. I just have some concern on removing the __no_optimization, I checked why it had added, then saw in this previous commit: seems like it will affect boards which using the ARC MWDT toolchain. I did not have a arcmwdt toolchain to verify it. Hi @IRISZZW , could you please help to check if this still causes problem now? (if we remove the __no_optimization) |
|
could set the vars volatile. |
Thank You Enjia for verifying it and looking into it. Yes, i am still looking into the __no_optimization attribute. |
|
Hi @yerabolu , any update on this PR? Thanks. |
| #if defined(CONFIG_MINIMAL_LIBC) && CONFIG_MINIMAL_LIBC_MALLOC_ARENA_SIZE == 0 | ||
| ZTEST_USER(lib_dynamic_memalloc, test_no_mem_malloc) | ||
| { | ||
| int *iptr = NULL; | ||
|
|
||
| iptr = malloc(BUF_LEN); | ||
| zassert_is_null((iptr), "malloc failed, errno: %d", errno); | ||
| free(iptr); | ||
| iptr = NULL; | ||
| } | ||
|
|
||
| ZTEST_USER(lib_dynamic_memalloc, test_no_mem_realloc) | ||
| { | ||
| char *ptr = NULL; | ||
| char *reloc_ptr = NULL; | ||
|
|
||
| reloc_ptr = realloc(ptr, BUF_LEN); | ||
| zassert_is_null(reloc_ptr, "realloc failed, errno: %d", errno); | ||
| free(reloc_ptr); | ||
| reloc_ptr = NULL; | ||
| } | ||
| #else |
There was a problem hiding this comment.
NAK.
Please keep __no_optimization function attribute. The potential issue is here and it won't go away as it's compiler valid behavior here to optimize out malloc / realloc in these cases.
Moreover it's not only related to MWDT - potentially it can be done by any toolcahin.
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
Migrating mem_alloc tests to new ztest API.
Part of #47002 effort
Signed-off-by: Spoorthy Priya Yerabolu spoorthy.priya.yerabolu@intel.com