Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: drivers: can: babbling: start can node #50283

Merged

Conversation

str4t0m
Copy link
Collaborator

@str4t0m str4t0m commented Sep 15, 2022

The device must be started before sending any frames.

Fixes: #50282

The device must be started before sending any frames.

Signed-off-by: Thomas Stranger <thomas.stranger@outlook.com>
Copy link
Member

@henrikbrixandersen henrikbrixandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd. I had that in my start/stop branch at some point, but it clearly wasn't in the version being merged. Thanks.

@henrikbrixandersen henrikbrixandersen added bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug labels Sep 15, 2022
@fabiobaltieri fabiobaltieri merged commit c1592fd into zephyrproject-rtos:main Sep 16, 2022
@str4t0m str4t0m deleted the can_samples_babbling_start branch August 16, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: CAN bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

samples: drivers: can: babbling: can controller not started.
5 participants