kernel: banner: cleanup implementation #51533
Conversation
The BOOT_DELAY option does nothing in code if MULTITHREADING is not enabled. Move the dependency to Kconfig instead. Signed-off-by: Jordan Yates <jordan.yates@data61.csiro.au>
Cleanup the mess of duplicate function definitions, unnecessary variables and duplicate strings. All banner strings are now constant in ROM. Also fixes a double space between the end of the version string and the trailing `***` when there is no boot delay. Signed-off-by: Jordan Yates <jordan.yates@data61.csiro.au>
JordanYates
requested review from
dcpleung,
nashif and
andyross
as code owners
| @@ -331,6 +331,7 @@ config BOOT_BANNER | |||
|
|
|||
| config BOOT_DELAY | |||
| int "Boot delay in milliseconds" | |||
| depends on MULTITHREADING | |||
There was a problem hiding this comment.
As I can see it doesn't actually depend on MULTITHREADING. Probably it's worth to drop this restriction?
There was a problem hiding this comment.
My understanding is that this delay is so that other threads can run and perform setup operations. Without MULTITHREADING what reason is there for the delay?
There was a problem hiding this comment.
It makes sense for certain tests. Please leave it without any dependency on multithreading.
There was a problem hiding this comment.
But the previous implementation did not delay at all when MULTITHREADING was disabled. Dropping that dependency would be a change in behaviour. This PR is only meant to cleanup the implementation.
There was a problem hiding this comment.
Not sure why we have that limitation. I'd say a clean-up could also simplify this by removing that condition.
There was a problem hiding this comment.
I am with @JordanYates, do not change behaviour in a cleanup PR. This keeps biting us.. If there is something to improve or fix, please do that in a different PR. In this case, I remember the issue and it was added for a reason: #14454
There was a problem hiding this comment.
Ok, fair enough :)
Cleanup the mess of duplicate function definitions, unnecessary variables and duplicate strings. All banner strings are now constant in ROM. Also fixes a double space between the end of the version string and the trailing
***when there is no boot delay.