scripts: west_commands: runners: remove deprecated options #52662
Conversation
The --snr (nrfjprog) --id (jlink) and --board-id (pyocd) options were deprecated a long time ago in favor of --dev-id. It is time to remove them. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
gmarull
force-pushed
the
nrfjprog-del-snr
branch
from
6602ae8
to
2b6c6dc
Compare
gmarull
changed the title
| args.extend(['--snr', TEST_OVR_SNR]) | ||
| args.extend(['--dev-id', TEST_OVR_SNR]) |
There was a problem hiding this comment.
should update all the other references to --snr in this file.
There was a problem hiding this comment.
nrfjprog uses --snr. let me tweak the test to make things more clear.
There was a problem hiding this comment.
Hmm, after checking I'm not sure removing SNR improves the code, as nrfjprog uses --snr and we're testing nrfjprog is run with the correct serial number, obtained from dev-id.
|
@gmarull I am not going to propose a revert, but for the record I would not have wanted to merge this PR. Just because we can remove deprecated features does not mean we should in all cases. In cases where the maintenance burden is minimal, the benefit of preserving backwards compatibility should not be ignored. I think this is such a case. |
Users had 1y to migrate from |
|
I don't agree with you. |
The --snr (nrfjprog) --id (jlink) and --board-id (pyocd) options were
deprecated a long time ago in favor of --dev-id. It is time to remove
them.
Ref. 5ee719e
Signed-off-by: Gerard Marull-Paretas gerard.marull@nordicsemi.no