mgmt: mcumgr: Add iterable section to register MCUmgr handlers #52923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordicjm
requested review from
carlescufi,
de-nordic,
nashif,
dcpleung and
andyross
as code owners
nordicjm
requested review from
galak,
MaureenHelm and
tejlmand
as code owners
nordicjm
changed the title
nordicjm
force-pushed
the
it_mcu
branch
2 times, most recently
from
e57e111
to
8844099
Compare
zephyrbot
added
Release Notes
|
Should probably make all the registration functions static too |
nordicjm
force-pushed
the
it_mcu
branch
2 times, most recently
from
49cf926
to
1c30a69
Compare
|
@tejlmand this one could do with your review, it touches the linker script. |
zephyrbot
requested review from
anangl,
jeremybettis,
laurenmurphyx64,
nashif and
stephanosio
This replaces the requirement for applications to manually register MCUmgr handlers by having an iterable section which then automatically registers the handlers at boot time. Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Adds a note on MCUmgr handlers now being automatically called without needing an application to manually register them. Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Makes group registration functions for MCUmgr handlers static as they are registered automatically at startup. Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
de-nordic
reviewed
Dec 21, 2022
This moves the UDP and Bluetooth initialisation for MCUmgr to be performed automatically with the new hander registration feature. Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Adds a note on MCUmgr Bluetooth and UDP transports now being automatically registered without needing an application to manually register them. Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
This application does not actually seem to use MCUmgr functionality, therefore remove it. Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
de-nordic
approved these changes
Dec 21, 2022
carlescufi
approved these changes
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation updateThere is no documentation about creating handlers, we should probably add this some time