Bluetooth: Controller: legacy conn param req caching and max central data PDU spacing #53095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvinayak
force-pushed
the
github_cen_spacing_cpr_cache_instant_passed_fix
branch
from
1b4d838
to
35d945d
Compare
jori-nordic
added a commit
to jori-nordic/zephyr
that referenced
this pull request
Dec 15, 2022
cvinayak
force-pushed
the
github_cen_spacing_cpr_cache_instant_passed_fix
branch
2 times, most recently
from
c4e7db9
to
617dacf
Compare
cvinayak
requested review from
alwa-nordic,
jhedberg,
Vudentz,
wopu-ot,
carlescufi,
thoh-ot and
kruithofa
as code owners
zephyrbot
requested review from
asbjornsabo,
erbr-ot,
hermabe,
jori-nordic,
mtpr-ot,
sjanc and
Thalley
Thalley
reviewed
Dec 15, 2022
| @@ -35,7 +35,7 @@ LL/CON/CEN/BV-21-C | |||
| LL/CON/CEN/BV-23-C | |||
| LL/CON/CEN/BV-24-C | |||
| LL/CON/CEN/BV-25-C | |||
| LL/CON/CEN/BV-26-C | |||
| #LL/CON/CEN/BV-26-C # This test case is not valid, and will fail with CPR cache | |||
There was a problem hiding this comment.
What is meant by not valid? Is the test case in the test spec broken? If so, is there an erratum for it?
There was a problem hiding this comment.
The test implementation is incorrect and hence has been disabled for refactored LLCP testing too, here:
kruithofa
previously approved these changes
Jan 19, 2023
Thalley
previously approved these changes
Jan 19, 2023
|
@cvinayak please rebase |
Fix legacy control procedure implementation to avoid connection update procedure with reason instant passed (0x28). Connection Update Indication PDU is enqueued after data enqueue to LLL context is paused and the enqueue resumes when already enqueued data PDUs are all acknowledged. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
Fix connection parameter request procedure to be cacheable if a remote control procedure is in progress. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
Use the maximum data PDU size time reservation space considering the Data length could be updated from default 27 bytes to maximum support size. If maximum time reservation is disabled then time space reservation corresponding to the default data length at the time of the start/enable of Central role is used. Note, currently this value is only used to space multiple central connections and not for actual ticker time reservations. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
cvinayak
force-pushed
the
github_cen_spacing_cpr_cache_instant_passed_fix
branch
from
617dacf
to
9bfb00d
Compare
Thalley
approved these changes
Jan 19, 2023
kruithofa
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix legacy control procedure implementation to avoid
connection update procedure with reason instant passed
(0x28).
Connection Update Indication PDU is enqueued after data
enqueue to LLL context is paused and the enqueue resumes
when already enqueued data PDUs are all acknowledged.
Fix connection parameter request procedure to be cacheable
if a remote control procedure is in progress.
Use the maximum data PDU size time reservation space
considering the Data length could be updated from default
27 bytes to maximum support size.
If maximum time reservation is disabled then time space
reservation corresponding to the default data length at the
time of the start/enable of Central role is used.
Note, currently this value is only used to space multiple central
connections and not for actual ticker time reservations.
Relates to #53007
Signed-off-by: Vinayak Kariappa Chettimada vich@nordicsemi.no