drivers: usb: udc: add STM32 UDC driver #53408
Conversation
|
@erwango , this PR now working with udc next stack and 96b_carbon, still need a bit of cleanup and should be ready for review/testing. |
loicpoulain
changed the title
loicpoulain
force-pushed
the
udc
branch
2 times, most recently
from
76f2bd7
to
d040a84
Compare
loicpoulain
force-pushed
the
udc
branch
3 times, most recently
from
b4aceba
to
e1ba4f8
Compare
| #include <zephyr/logging/log.h> | ||
| #include <zephyr/irq.h> | ||
|
|
||
| #include <zephyr/logging/log.h> |
There was a problem hiding this comment.
included second time, see L27
| #if DT_HAS_COMPAT_STATUS_OKAY(st_stm32_otghs) | ||
| #define DT_DRV_COMPAT st_stm32_otghs | ||
| #elif DT_HAS_COMPAT_STATUS_OKAY(st_stm32_otgfs) | ||
| #define DT_DRV_COMPAT st_stm32_otgfs | ||
| #elif DT_HAS_COMPAT_STATUS_OKAY(st_stm32_usb) | ||
| #define DT_DRV_COMPAT st_stm32_usb | ||
| #endif |
There was a problem hiding this comment.
Will it work with multiple driver instances, FS + HS?
There was a problem hiding this comment.
The way I remember it, the HS and FS are mutually exclusive at the hardware level. Do I recall correctly or can these actually be used simultaneously?
There was a problem hiding this comment.
It appears to be possible, see stm32f7-usbfs-and-usbhs-together This being said, it isn't possible in current driver version so this is not a new limitation which is being added here. Driver could be converted later to multiple, heterogeneous instances.
There was a problem hiding this comment.
Okay. Just for notice, the native implementation for DWC2 controller will support multiple FS/HS instances combination.
drivers/usb/udc/udc_stm32.c
Outdated
| { | ||
| struct udc_stm32_data *priv = hpcd2data(hpcd); | ||
|
|
||
| LOG_DBG(""); |
There was a problem hiding this comment.
I do not mind, but this kind of tracing is now unwanted.
Better something like LOG_DBG("Submit reset event");.
drivers/usb/udc/udc_stm32.c
Outdated
| } | ||
| #endif /* USB_OTG_FS || USB_OTG_HS */ | ||
|
|
||
| static void __pcd_prepare(const struct device *dev) |
There was a problem hiding this comment.
IIRC, we must not use __ for this, better hal_driver_ prefix, or priv_, or instance_.
|
@erwango , it should work now with nucleo_wb55rg! |
|
Thanks for the fix. Performing extended validation, I'm seeing following issues:
|
There was a problem hiding this comment.
@loicpoulain can you please document in the message what STM32 platform is supported/tested in this state of the driver (g.e STM32F4 family is supported) so we can move forward? Support for additional platforms can be added later. Thanks.
erwango
dismissed
their stale review
As this is still experimental, ok to move on.
Done, note that my testing shows that b_u585i_iot2a fails with cdc_acm sample at runtime, but it seems the same with 'legacy' driver, so... need further investigations. |
Add UDC driver for STM32 based MCU, relying on HAL/PCD. This has been tested with cdc_acm sample on the following boards: - 96b_carbon (STM32F4) - disco_l475_iot1 (STM32L4) - nucleo_wb55rg (STM32WB) - nucleo_h723zg (STM32H7) - stm32f3_disco (STM32F3) This fails at runtime for the following: - b_u585i_iot2a (STM32U5) Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
This board can rely on udc_stm32 usbd-next driver. Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
Add UDC driver for STM32 based MCU, relying on HAL/PCD.
Implementing: #42066
Tested-on:
96b_carbon - cdc_acm sample - CONF_FILE=usbd_next_prj.conf
disco_l475_iot1 - cdc_acm sample - CONF_FILE=usbd_next_prj.conf
nucleo_wb55rg - cdc_acm sample - CONF_FILE=usbd_next_prj.conf
nucleo_h723zg - cdc_acm sample - CONF_FILE=usbd_next_prj.conf
west build -b nucleo_wb55rg -- -DCONF_FILE=usbd_next_prj.conf