Bluetooth: ISO advanced qos #53945
Merged
Bluetooth: ISO advanced qos #53945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
force-pushed
the
iso_advanced_qos
branch
3 times, most recently
from
e9f7bee
to
9050aca
Compare
Thalley
requested review from
alwa-nordic,
jhedberg,
Vudentz,
wopu-ot and
sjanc
as code owners
Thalley
force-pushed
the
iso_advanced_qos
branch
2 times, most recently
from
6b7d643
to
af13aa0
Compare
Thalley
force-pushed
the
iso_advanced_qos
branch
from
af13aa0
to
beeb0d1
Compare
|
Rebased to solve merge conflicts |
Thalley
force-pushed
the
iso_advanced_qos
branch
from
beeb0d1
to
c27cee3
Compare
Thalley
force-pushed
the
iso_advanced_qos
branch
from
c27cee3
to
1881e69
Compare
Thalley
force-pushed
the
iso_advanced_qos
branch
from
1881e69
to
74b5c7d
Compare
|
Rebased to solve merge conflicts |
1 similar comment
|
Rebased to solve merge conflicts |
zephyrbot
requested review from
carlescufi,
cvinayak,
erbr-ot,
kruithofa,
mtpr-ot and
thoh-ot
kruithofa
reviewed
May 15, 2023
|
|
||
| printk("Follow the prompts. Press enter to use default values.\n"); | ||
| printk("Follow the ptompts. Press enter to use default values.\n"); |
There was a problem hiding this comment.
Suggested change
| printk("Follow the ptompts. Press enter to use default values.\n"); | |
| printk("Follow the prompts. Press enter to use default values.\n"); |
| } | ||
|
|
||
| num_subevents = strtoul(buffer, NULL, 0); | ||
| if (num_subevents > BT_ISO_NSE_MAX) { |
There was a problem hiding this comment.
there is no check to verify that the NSE is at least BT_ISO_NSE_MIN. In other words it is possible to enter 0 for the number of subevents. Same for the other parameters
There was a problem hiding this comment.
Added checks for minimum values for both this and the connected ISO benchmark sample
Thalley
force-pushed
the
iso_advanced_qos
branch
2 times, most recently
from
ba92056
to
34c117e
Compare
Thalley
force-pushed
the
iso_advanced_qos
branch
from
34c117e
to
a66ab57
Compare
Add support for setting advanced unicast ISO parameters using the ISO test commands. This allows the host to set ISO parameters that the controller normally would handle. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
The RTN value range for broadcast is more limited than connected ISO. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
Add (optional) advanced ISO support for the benchmark ISO sample. The CONFIG_BT_ISO_ADVANCED Kconfig simply needs to be enabled in order to support the advanced settings. This also reduces the number of default channels supported to 1. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
Add support for setting advanced broadcast ISO parameters using the ISO test commands. This allows the host to set ISO parameters that the controller normally would handle. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
Add (optional) advanced ISO support for the benchmark ISO sample. The CONFIG_BT_ISO_ADVANCED Kconfig simply needs to be enabled in order to support the advanced settings. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
Refactor the test function to split it into multiple smaller functions. This makes the main function much shorter and easier to follow, and allows reusing of the individual steps. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
Extended the ISO broadcaster BSIM test with an additional step to create a BIG using the test parameters. Since this isn't properly implemented in the controller, CONFIG_BT_ISO_ADVANCED has not been enabled in the prj.conf yet. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
Thalley
force-pushed
the
iso_advanced_qos
branch
from
a66ab57
to
64185ab
Compare
alwa-nordic
approved these changes
Jul 3, 2023
kruithofa
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for setting advanced ISO settings for CIGs and BIGs. This also adds support for the new settings in the benchmark samples.
fixes #50949