drivers: regulator: Add NXP VREF driver #56822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decsny
requested review from
nashif,
carlescufi,
galak,
MaureenHelm,
mmahadevan108,
dleach02,
gmarull and
anangl
as code owners
zephyrbot
added
area: Regulators
platform: NXP
zephyrbot
requested review from
danieldegrasse,
DerekSnell,
EmilioCBen,
manuargue and
yvanderv
gmarull
requested changes
Apr 14, 2023
| const struct regulator_nxp_vref_config *config = dev->config; | ||
| const VREF_Type *base = (VREF_Type *) config->base; | ||
|
|
||
| volatile uint32_t *const csr = (volatile uint32_t *const) &base->CSR; |
There was a problem hiding this comment.
Why declare this? You can just reference base->CSR in the function. I guess compiler should optimize this anyways, just not sure why we add it.
| * Disable HC Bandgap, LP Bandgap, and Buf21 | ||
| * to achieve "Off" mode of VREF | ||
| */ | ||
| *csr &= ~VREF_CSR_HCBGEN_MASK; |
There was a problem hiding this comment.
It doesn't seen like the VREF_CSR_BUF21EN_MASK is being cleared here, contrary to what comment suggests.
decsny
force-pushed
the
feature/nxp_vref
branch
3 times, most recently
from
4d1f4a7
to
658e052
Compare
decsny
force-pushed
the
feature/nxp_vref
branch
2 times, most recently
from
0659acb
to
a5759a6
Compare
|
@gmarull can you revisit this PR? I marked your comments as resolved if I thought I addressed them just to navigate the thread easier, but feel free to unresolve if needed. I would like to make progress on this because there are multiple platforms and multiple other IP blocks that depend on this one. |
gmarull
reviewed
Aug 22, 2023
decsny
force-pushed
the
feature/nxp_vref
branch
from
a5759a6
to
41c6971
Compare
|
@gmarull I think I addressed your comments, can you check? |
Add binding, include header, and driver for NXP VREF IP block. NXP VREF is an internal voltage reference generator on some SOCs that fits well with the regulator API in zephyr. Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
Add node for VREF0 peripheral to LPC55S3X SOC DT Clock VREF peripheral if status = okay in DT Enable VREF on lpcxpresso55s36 Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
Add phandle prop to reference any regulator that must be enabled in order for the LPADC to function as intended. Change LPADC driver to use this property if present. LPADC on LPC55S36 depends on VREF peripheral, enable for this platform. Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
Support lpcxpresso55s36 on regulator voltage test using VREF Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
decsny
force-pushed
the
feature/nxp_vref
branch
from
41c6971
to
0b98a62
Compare
gmarull
approved these changes
Sep 20, 2023
|
@danieldegrasse @aasinclair review ping |
aasinclair
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VREF is a peripheral on NXP's LPC55S36 which generates a reference voltage and can take advantage of an internal regulator to keep the signal stable. This SOC peripheral fits nicely into the Zephyr regulator API, so in this PR I am adding a Zephyr native driver for this peripheral. To show that it is somewhat functional, I replaced the VREF SDK code in init for LPC55S36, which is needed to use LPADC, with a call to enable the regulator(s) in the LPADC driver that it needs to function.