drivers: adc: Add support for TI ADS1112 ADCs #56826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmontgomery-cruise
requested review from
nashif,
galak and
anangl
as code owners
zephyrbot
added
area: ADC
jmontgomery-cruise
force-pushed
the
add_ads1112_driver
branch
3 times, most recently
from
8929f9f
to
fd99dfb
Compare
|
@anangl please take a look @jmontgomery-cruise please address the failed scancode check |
jmontgomery-cruise
force-pushed
the
add_ads1112_driver
branch
6 times, most recently
from
41208d8
to
e58f901
Compare
jmontgomery-cruise
force-pushed
the
add_ads1112_driver
branch
from
e58f901
to
21443f0
Compare
|
@anangl Is there any chance this can be reviewed? |
MaureenHelm
previously approved these changes
May 26, 2023
anangl
reviewed
May 26, 2023
This PR adds a custom driver for the ADS1112 ADCs. Unlike ADS1113/4/5 family served by the ADS1x1x driver, the ADS1112 does not use an address pointer to address config registers. Instead, there is only one writable register and all i2c writes will set it. The registers resemble the ADS1119 device, but config bitmap is different, include a distinct data rate table, gain table, and input multiplexing table. There is also not a status register to be monitored with the ADS1112, as it uses config bit 7 for the same purpose instead of a separate register. The driver was tested on hardware using the ADC shell interface. Manual probing validated the voltages for the MUX_SINGLE configs at datarate 15 in CM_SINGLE. Higher gains were not tested and CM_CONTINUOUS is not supported in this initial implementation. The new driver has also been added to the existing ADC test using adc_emul for completeness. Origin: original License: Apache 2.0 Purpose: Adding support for ADS1112 ADCs Signed-off-by: Jordan Montgomery <jordan.montgomery@getcruise.com>
The adc-shell uses a hardcoded list of defines to check whether it should throw a compile-time error. The ADS1119 and ADS1112 driver both support the APIs needed by the shell, so this commit enables support for them in the hardcoded support list. Signed-off-by: Jordan Montgomery <jordan.montgomery@getcruise.com>
jmontgomery-cruise
force-pushed
the
add_ads1112_driver
branch
from
21443f0
to
14fe005
Compare
anangl
approved these changes
Jun 12, 2023
MaureenHelm
approved these changes
Jun 14, 2023
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi @jmontgomery-cruise!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!
To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.
Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a custom driver for the ADS1112 ADCs. Unlike the ADS1113/4/5 family served by the ADS1x1x driver, the ADS1112 does not use an address pointer to access config registers. Instead, there is only one writable register and all i2c writes will set it. The register "map" resembles the ADS1119 device, but still has significant differences.
Notably, the config bitmap is different and includes a distinct data rate table, gain table, and input multiplexing table. Unlike the ADS1119, there isn't a status register, as config bit 7 serves the same purpose on the ADS1112.
The new driver has also been added to the existing ADC test using adc_emul for completeness. A second commit on top adds both this new driver and the existing ADS1119 driver to the adc-shell.c whitelist.
The new driver was tested on real hardware using the adc shell and correct voltages were observed in the configs used. Continuous sampling mode is not supported by this initial implementation.