drivers: sensor: bmm150: Add trigger support for bmm150 magnetometer … #57985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Sensors
Cherish-Gww
force-pushed
the
sensor_bmm150
branch
2 times, most recently
from
2b06420
to
bf3bdb4
Compare
MaureenHelm
requested changes
May 18, 2023
Cherish-Gww
force-pushed
the
sensor_bmm150
branch
2 times, most recently
from
fbe0bc6
to
fa4c3e3
Compare
MaureenHelm
requested changes
May 23, 2023
There was a problem hiding this comment.
Please address the failed twister check:
In file included from /__w/zephyr/zephyr/drivers/sensor/bmm150/bmm150_trigger.c:15:
/__w/zephyr/zephyr/drivers/sensor/bmm150/bmm150.h:175:22: error: duplicate member ‘sem’
175 | struct k_sem sem;
| ^~~
/__w/zephyr/zephyr/drivers/sensor/bmm150/bmm150_trigger.c: In function ‘bmm150_handle_interrupts’:
/__w/zephyr/zephyr/drivers/sensor/bmm150/bmm150_trigger.c:24:19: error: ‘struct bmm150_data’ has no member named ‘drdy_handler’; did you mean ‘drdy_handle’?
24 | if (data->drdy_handler) {
| ^~~~~~~~~~~~
| drdy_handle
/__w/zephyr/zephyr/drivers/sensor/bmm150/bmm150_trigger.c:25:23: error: ‘struct bmm150_data’ has no member named ‘drdy_handler’; did you mean ‘drdy_handle’?
25 | data->drdy_handler(dev, data->drdy_trigger);
| ^~~~~~~~~~~~
| drdy_handle
/__w/zephyr/zephyr/drivers/sensor/bmm150/bmm150_trigger.c: In function ‘bmm150_trigger_set’:
/__w/zephyr/zephyr/drivers/sensor/bmm150/bmm150_trigger.c:102:15: error: ‘struct bmm150_data’ has no member named ‘drdy_handler’; did you mean ‘drdy_handle’?
102 | data->drdy_handler = handler;
| ^~~~~~~~~~~~
| drdy_handle
fa4c3e3
to
164bdd3
Compare
MaureenHelm
previously approved these changes
May 24, 2023
Cherish-Gww
force-pushed
the
sensor_bmm150
branch
from
77c10b9
to
57d64bd
Compare
|
@MaureenHelm Do you still have any issues with this patch ? |
MaureenHelm
previously approved these changes
Jul 17, 2023
Cherish-Gww
force-pushed
the
sensor_bmm150
branch
from
57d64bd
to
618c677
Compare
MaureenHelm
previously approved these changes
Jul 26, 2023
|
@Cherish-Gww please rebase |
…sensor Add bmm150 magetometer sensor data ready trigger support. Signed-off-by: Weiwei Guo <guoweiwei@syriusrobotics.com>
Cherish-Gww
force-pushed
the
sensor_bmm150
branch
from
618c677
to
133b535
Compare
MaureenHelm
approved these changes
Sep 5, 2023
carlescufi
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sensor