dts: bindings: interrupt-controller: GIC: Allow specifying version in DT #58035
Conversation
When the GIC driver was originally introduced, it was only used on Cortex-R SoCs. However, this is not the case anymore. Update the description to reflect that this driver is not specific to Cortex-R. Signed-off-by: Piotr Wojnarowski <pwojnarowski@antmicro.com>
p-woj
requested review from
galak,
aaillet,
pmarzin,
bbolen,
stephanosio,
manuargue,
carlocaione,
dcpleung,
nashif,
lorc,
firscity,
povergoing,
ibirnbaum,
MaureenHelm and
ioannisg
as code owners
zephyrbot
added
area: ARM64
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @p-woj, and thank you very much for your first pull request to the Zephyr project!
A project maintainer just triggered our CI pipeline to run it against your PR and ensure it's compliant and doesn't cause any issues. You might want to take this opportunity to review the project's Contributor Expectations and make any updates to your pull request if necessary. 😊
|
LGTM, but someone who has downstream board patches might have to update their DTS :) |
| config GIC_V1 | ||
| bool | ||
| def_bool DT_HAS_ARM_GIC_V1_ENABLED |
There was a problem hiding this comment.
For consistency this should be:
default y
depends on ...
Currently, only the presence of a GIC is reflected in the device tree, and its version must be set separately in each SoC's Kconfig. This patch adds separate bindings for each GIC version whose presence in the device tree automatically enables the corresponding Kconfig symbol. Signed-off-by: Piotr Wojnarowski <pwojnarowski@antmicro.com>
|
I've adjusted the Kconfig changes so that they don't break out-of-tree boards anymore. Now both ways of specifying the architecture version ( Also, having the version explicitly selected in Kconfig without the versioned compat in the DT prints a deprecation warning. Please take a look @carlocaione |
doc/releases/release-notes-3.4.rst
Outdated
| * Setting the GIC architecture version by selecting | ||
| :kconfig:option:`CONFIG_GIC_V1`, :kconfig:option:`CONFIG_GIC_V2` and | ||
| :kconfig:option:`CONFIG_GIC_V3` directly in Kconfig has been deprecated. | ||
| The GIC version should now be specified by adding the appropriate compatible, for | ||
| example :dtcompatible:`arm,gic-v2`, to the GIC node in the device tree. |
There was a problem hiding this comment.
This should go now in the 3.5 release notes.
Add a base working release notes file for the Zephyr 3.5 release. Signed-off-by: Piotr Wojnarowski <pwojnarowski@antmicro.com>
Add a note that explains that the GIC version is now specified in the DT and not Kconfig. Signed-off-by: Piotr Wojnarowski <pwojnarowski@antmicro.com>
Move the GIC version to the device tree for xilinx_zynq7000 to improve readability Signed-off-by: Piotr Wojnarowski <pwojnarowski@antmicro.com>
Move the GIC version to the device tree for nxp_s32 to improve readability Signed-off-by: Piotr Wojnarowski <pwojnarowski@antmicro.com>
Move the GIC version to the device tree for cyclonev to improve readability Signed-off-by: Piotr Wojnarowski <pwojnarowski@antmicro.com>
Move the GIC version to the device tree for renesas_rcar to improve readability Signed-off-by: Piotr Wojnarowski <pwojnarowski@antmicro.com>
Move the GIC version to the device tree for xilinx_zynqmp to improve readability Signed-off-by: Piotr Wojnarowski <pwojnarowski@antmicro.com>
Move the GIC version to the device tree for fvp_aemv8{a,r}
to improve readability
Signed-off-by: Piotr Wojnarowski <pwojnarowski@antmicro.com>
Move the GIC version to the device tree for viper to improve readability Signed-off-by: Piotr Wojnarowski <pwojnarowski@antmicro.com>
Move the GIC version to the device tree for mimx9 to improve readability Signed-off-by: Piotr Wojnarowski <pwojnarowski@antmicro.com>
Move the GIC version to the device tree for the QEMU platforms to improve readability Signed-off-by: Piotr Wojnarowski <pwojnarowski@antmicro.com>
Move the GIC version to the device tree for nxp_imx to improve readability Signed-off-by: Piotr Wojnarowski <pwojnarowski@antmicro.com>
Move the GIC version to the device tree for intel_socfpga to improve readability Signed-off-by: Piotr Wojnarowski <pwojnarowski@antmicro.com>
Move the GIC version to the device tree for rk3399 to improve readability Signed-off-by: Piotr Wojnarowski <pwojnarowski@antmicro.com>
Move the GIC version to the device tree for am6x to improve readability Signed-off-by: Piotr Wojnarowski <pwojnarowski@antmicro.com>
Move the GIC version to the device tree for ls1046a to improve readability Signed-off-by: Piotr Wojnarowski <pwojnarowski@antmicro.com>
Move the GIC version to the device tree for xenvm to improve readability Signed-off-by: Piotr Wojnarowski <pwojnarowski@antmicro.com>
There was a problem hiding this comment.
Hi @p-woj!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!
To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.
Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁
This PR separates the GIC binding into 3 version-specific ones and moves the GIC version from the SoCs' Kconfigs into their device trees. This brings the GIC driver more in line with other existing drivers and makes the device tree a more complete description of the hardware, which is useful for efforts relying on structured data such as Renodepedia.