sensors: Create sensor trig subcommand
#58257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yperess
requested changes
May 25, 2023
tristan-google
force-pushed
the
sensor-shell-trigger-subcmd
branch
from
e90c8f0
to
0070ded
Compare
yperess
previously approved these changes
May 25, 2023
teburd
requested changes
May 25, 2023
tristan-google
force-pushed
the
sensor-shell-trigger-subcmd
branch
from
0070ded
to
4b4df58
Compare
yperess
previously approved these changes
May 25, 2023
teburd
previously approved these changes
May 25, 2023
|
needs rebase |
This PR relocates the sensor trigger sample application from the `sensor_shell` sample to a subcommand in the actual sensor shell. The subcommand has a UI for enabling a given trigger on a given sensor. A built-in handler for the data_ready trigger is included that prints the latest data to the log. Currently, only `SENSOR_TRIG_DATA_READY` is supported but the groundwork is there to add others. Tested on a `tdk_robokit1` board. Signed-off-by: Tristan Honscheid <honscheid@google.com>
tristan-google
force-pushed
the
sensor-shell-trigger-subcmd
branch
from
4b4df58
to
1d7029d
Compare
nashif
approved these changes
May 26, 2023
teburd
approved these changes
May 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relocates the sensor trigger sample application from the
sensor_shellsample to a subcommand in the actual sensor shell. The subcommand has a UI for enabling a given trigger on a given sensor. A built-in handler for the data_ready trigger is included that prints the latest data to the log. Currently, onlySENSOR_TRIG_DATA_READYis supported but the groundwork is there to add others. Tested on atdk_robokit1board.