boards: nucleo_*: add ST Morpho connector nexus nodes #59754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mniestroj
changed the title
Add a new GPIO nexus node for the ST Morpho connector in the board. Signed-off-by: Marcin Niestroj <m.niestroj@emb.dev>
Add a new GPIO nexus node for the ST Morpho connector in the board. Signed-off-by: Marcin Niestroj <m.niestroj@emb.dev>
Add a new GPIO nexus node for the ST Morpho connector in the board. Signed-off-by: Marcin Niestroj <m.niestroj@emb.dev>
Add a new GPIO nexus node for the ST Morpho connector in the board. Signed-off-by: Marcin Niestroj <m.niestroj@emb.dev>
Add a new GPIO nexus node for the ST Morpho connector in the board. Signed-off-by: Marcin Niestroj <m.niestroj@emb.dev>
Add a new GPIO nexus node for the ST Morpho connector in the board. Signed-off-by: Marcin Niestroj <m.niestroj@emb.dev>
Add a new GPIO nexus node for the ST Morpho connector in the board. Signed-off-by: Marcin Niestroj <m.niestroj@emb.dev>
Add a new GPIO nexus node for the ST Morpho connector in the board. Signed-off-by: Marcin Niestroj <m.niestroj@emb.dev>
Add a new GPIO nexus node for the ST Morpho connector in the board. Signed-off-by: Marcin Niestroj <m.niestroj@emb.dev>
Add a new GPIO nexus node for the ST Morpho connector in the board. Signed-off-by: Marcin Niestroj <m.niestroj@emb.dev>
Add a new GPIO nexus node for the ST Morpho connector in the board. Signed-off-by: Marcin Niestroj <m.niestroj@emb.dev>
Add a new GPIO nexus node for the ST Morpho connector in the board. Signed-off-by: Marcin Niestroj <m.niestroj@emb.dev>
Add a new GPIO nexus node for the ST Morpho connector in the board. Signed-off-by: Marcin Niestroj <m.niestroj@emb.dev>
Add a new GPIO nexus node for the ST Morpho connector in the board. Signed-off-by: Marcin Niestroj <m.niestroj@emb.dev>
Add a new GPIO nexus node for the ST Morpho connector in the board. Signed-off-by: Marcin Niestroj <m.niestroj@emb.dev>
mniestroj
force-pushed
the
nucleo-st-morpho
branch
from
90f3d5f
to
dc18150
Compare
gautierg-st
reviewed
Jun 30, 2023
| st_morpho_header: st-morpho-header { | ||
| compatible = "st-morpho-header"; | ||
| #gpio-cells = <2>; | ||
| gpio-map-mask = <ST_MORPHO_PIN_MASK 0x0>; |
There was a problem hiding this comment.
Are you certain about this? I had a look in doc/hardware/porting/shields.rst to try to understand what it is and I'd say we should keep the same value as the Arduino connectors.
There was a problem hiding this comment.
Actually I am not. I have just copy-pasted it from other ST Morpho nexus nodes introduced in #57468.
At least I have tested it with Semtech SX1276MB1MAS shield (not upstream yet) and it worked with different GPIO flags used.
There was a problem hiding this comment.
Ok, I'm not too sure about it myself to be honest. If it works as is, then it's a go, but I would still like another opinion, or better, an explanation on this mask.
gautierg-st
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ST Morpho connector nodes for all upstream boards documented in
UM1724 User Manual for STM32 Nucleo-64 boards (MB1136).