Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add STM32L451 #59763

Merged
merged 1 commit into from Jul 6, 2023
Merged

Conversation

benediktibk
Copy link
Collaborator

Add the MCU STM32L451.

@benediktibk benediktibk marked this pull request as ready for review June 28, 2023 08:38
@zephyrbot zephyrbot added the platform: STM32 ST Micro STM32 label Jun 28, 2023
@benediktibk
Copy link
Collaborator Author

My approach was to copy the files from the L452 and work through the differences of these two MCUs according to their datasheets. I tested it on a custom PCB, and the basic functionality (RCC, clocks, UART, GPIOs, UART, ...) is fine.

gautierg-st
gautierg-st previously approved these changes Jun 30, 2023
Copy link
Contributor

@gautierg-st gautierg-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved because it seems correct, but from what I see, the only difference between L451 and L452 is the USB in the 52. Thus, it would be nice to include the 51 in the 52, and remove all nodes but the USB. That would avoid unnecessary duplication.

@benediktibk
Copy link
Collaborator Author

Approved because it seems correct, but from what I see, the only difference between L451 and L452 is the USB in the 52. Thus, it would be nice to include the 51 in the 52, and remove all nodes but the USB. That would avoid unnecessary duplication.

I introduced a base called L45 and included it in L451 and L452.

@gautierg-st
Copy link
Contributor

Thank you for this, but I don't think it is necessary to introduce a stm32l45.dtsi. It is perfectly fine to use stm32l451.dtsi as a base. This is how it's done on other series and it would be better to keep the same structure.

Add the MCU STM32L451.

Signed-off-by: Benedikt Schmidt <benedikt.schmidt@embedded-solutions.at>
@benediktibk
Copy link
Collaborator Author

Thank you for this, but I don't think it is necessary to introduce a stm32l45.dtsi. It is perfectly fine to use stm32l451.dtsi as a base. This is how it's done on other series and it would be better to keep the same structure.

Done

Copy link
Contributor

@gautierg-st gautierg-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@erwango erwango requested a review from carlescufi July 6, 2023 07:08
@fabiobaltieri fabiobaltieri merged commit 42051fc into zephyrproject-rtos:main Jul 6, 2023
17 checks passed
@benediktibk benediktibk deleted the add_stm32l451 branch July 6, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: STM32 ST Micro STM32
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants