New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ADC driver for EFM32 #60002
Add ADC driver for EFM32 #60002
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @wsipak, and thank you very much for your first pull request to the Zephyr project!
A project maintainer just triggered our CI pipeline to run it against your PR and ensure it's compliant and doesn't cause any issues. You might want to take this opportunity to review the project's Contributor Expectations and make any updates to your pull request if necessary. 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -18,5 +18,6 @@ config SOC_SERIES_EFM32PG1B | |||
select SOC_GECKO_CMU |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be in soc/arm/silabs_exx32/efm32pg12b/Kconfig.series?
The boards/arm/efm32pg_stk3402a/efm32pg_stk3402a.dts has #include <silabs/efm32pg12b500f1024gl125.dtsi>.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I think you're right. I've fixed this.
This adds a driver for ADCs available on EFM32 Signed-off-by: Wojciech Sipak <wsipak@antmicro.com>
This adds a proper ADC node that uses the gecko-adc driver. Signed-off-by: Wojciech Sipak <wsipak@antmicro.com>
ping @anangl |
This adds ADC driver for Silicon Labs Gecko Series 1 ADC, and ADC node using this driver for the
efm32pg_stk3402a
board.