Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ADC driver for EFM32 #60002

Merged
merged 2 commits into from Jul 18, 2023
Merged

Conversation

wsipak
Copy link
Contributor

@wsipak wsipak commented Jul 4, 2023

This adds ADC driver for Silicon Labs Gecko Series 1 ADC, and ADC node using this driver for the efm32pg_stk3402a board.

@zephyrbot zephyrbot added platform: SiLabs Silicon Labs area: ADC Analog-to-Digital Converter (ADC) area: Devicetree Binding PR modifies or adds a Device Tree binding labels Jul 4, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @wsipak, and thank you very much for your first pull request to the Zephyr project!

A project maintainer just triggered our CI pipeline to run it against your PR and ensure it's compliant and doesn't cause any issues. You might want to take this opportunity to review the project's Contributor Expectations and make any updates to your pull request if necessary. 😊

fkokosinski
fkokosinski previously approved these changes Jul 5, 2023
Copy link
Member

@fkokosinski fkokosinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -18,5 +18,6 @@ config SOC_SERIES_EFM32PG1B
select SOC_GECKO_CMU

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be in soc/arm/silabs_exx32/efm32pg12b/Kconfig.series?
The boards/arm/efm32pg_stk3402a/efm32pg_stk3402a.dts has #include <silabs/efm32pg12b500f1024gl125.dtsi>.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I think you're right. I've fixed this.

This adds a driver for ADCs available on EFM32

Signed-off-by: Wojciech Sipak <wsipak@antmicro.com>
This adds a proper ADC node that uses the gecko-adc driver.

Signed-off-by: Wojciech Sipak <wsipak@antmicro.com>
@wsipak
Copy link
Contributor Author

wsipak commented Jul 13, 2023

ping @anangl
Could you please review this as the ADC maintainer? Thank you.

@fabiobaltieri fabiobaltieri merged commit 6fe0169 into zephyrproject-rtos:main Jul 18, 2023
18 checks passed
@tgorochowik tgorochowik deleted the wsip/efm32-adc branch July 18, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ADC Analog-to-Digital Converter (ADC) area: Devicetree Binding PR modifies or adds a Device Tree binding platform: SiLabs Silicon Labs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants