Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boards: Add da14695 dk usb #60086

Merged

Conversation

NiekIlmer
Copy link
Contributor

This PR adds support for the DA14695 USB kit

Three commits in this PR:
-add UART2 and 3 DT bindings for DA1469x
-add the DA14695 variant thats used on this board
-add board files for da14695_dk_usb

@MaureenHelm
Copy link
Member

@andrzej-kaczmarek please take a look
@NiekIlmer can you fix the failed CI check please?

Copy link
Collaborator

@andrzej-kaczmarek andrzej-kaczmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, but please fix commits order to match dependencies (i.e. board depends on SoC, not the other way round) and make prefixes in commit titles lowercase to match existing commits

boards/arm/da14695_dk_usb/da14695_dk_usb-pinctrl.dtsi Outdated Show resolved Hide resolved
@NiekIlmer NiekIlmer force-pushed the add_da14695_dk_usb branch 2 times, most recently from aea6197 to 9604897 Compare August 22, 2023 11:31
This commits adds the DA14695 variant.
The main difference with the DA14699 is a smaller package with less
GPIO.

Signed-off-by: Niek Ilmer <niek.ilmer.aj@renesas.com>
This commit adds devicetree bindings for UART2 and 3

Signed-off-by: Niek Ilmer <niek.ilmer.aj@renesas.com>
This commit adds board files for the da14695_dk_usb.
The board features two Mikrobus sockets, these are added to the dts

Signed-off-by: Niek Ilmer <niek.ilmer.aj@renesas.com>
Copy link
Member

@aaillet aaillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Have you run the twister test suite and basic tests on real hardware?

@fabiobaltieri fabiobaltieri added this to the v3.6.0 milestone Oct 17, 2023
@NiekIlmer
Copy link
Contributor Author

Hi @aaillet,

We ran the Zephyr kernel tests on the usb devkit without errors. We're in the process of setting up a full testing setup with multiple devkits.

Kind regards,

Niek Ilmer

@carlescufi carlescufi merged commit bbba08f into zephyrproject-rtos:main Oct 20, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: Renesas SmartBond Renesas Electronics Corporation, SmartBond
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

7 participants