Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Silabs SLTB009A Board #60137

Merged
merged 3 commits into from Jul 25, 2023
Merged

Add Silabs SLTB009A Board #60137

merged 3 commits into from Jul 25, 2023

Conversation

wsipak
Copy link
Contributor

@wsipak wsipak commented Jul 7, 2023

This adds a new board featuring EFM32GG12B MCU.

Here's a necessary update to HAL:
zephyrproject-rtos/hal_silabs#33

  • Add Silabs EFM32GG12B SoC
  • Add Silabs SLTB009A board

@zephyrbot zephyrbot added the platform: SiLabs Silicon Labs label Jul 7, 2023
@zephyrbot zephyrbot added manifest manifest-hal_silabs DNM This PR should not be merged (Do Not Merge) labels Jul 7, 2023
@zephyrbot
Copy link
Collaborator

zephyrbot commented Jul 7, 2023 •
edited

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_silabs zephyrproject-rtos/hal_silabs@a143f03 zephyrproject-rtos/hal_silabs@5fbe78d (master) zephyrproject-rtos/hal_silabs@a143f03e..5fbe78d3

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@fkokosinski fkokosinski mentioned this pull request Jul 10, 2023
Merged
fkokosinski
fkokosinski previously approved these changes Jul 11, 2023
View reviewed changes
tgorochowik
tgorochowik previously approved these changes Jul 18, 2023
View reviewed changes
@fkokosinski
Copy link
Member

Hi @wsipak!

I've merged your HAL PR. Please rebase and update the HAL revision in west.yml that you're using in this PR to 5fbe78d3676b5500585f8e4534a8e56e7dae74a8 (the newest commit sha in hal_silabs)

@wsipak wsipak dismissed stale reviews from tgorochowik and fkokosinski via 4c7016c July 18, 2023 11:26
@zephyrbot zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Jul 18, 2023
@wsipak
Copy link
Contributor Author

wsipak commented Jul 18, 2023

@fkokosinski
Thank you, I've edited west.yml accordingly.

fkokosinski
fkokosinski previously approved these changes Jul 19, 2023
View reviewed changes
tgorochowik
tgorochowik previously approved these changes Jul 19, 2023
View reviewed changes
fabiobaltieri
fabiobaltieri requested changes Jul 19, 2023
View reviewed changes
Copy link
Member

@fabiobaltieri fabiobaltieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, can you add some docs for the board? It's normally required for adding boards upstream: https://docs.zephyrproject.org/latest/hardware/porting/board_porting.html#contributing-your-board, we like pretty board pictures :-) (actually we like pixelated low res low space board pictures)

@wsipak
west.yml: update Silabs HAL
5456daf 
Silabs HAL introduces support for EFM32GG12B SoC.

Signed-off-by: Wojciech Sipak <wsipak@antmicro.com>
@wsipak
boards: arm: add efm32gg_sltb009a board
6db0331 
- Add Silabs SLTB009A board
- Add Silabs EFM32GG12B SoC

Signed-off-by: Wojciech Sipak <wsipak@antmicro.com>
@wsipak wsipak dismissed stale reviews from tgorochowik and fkokosinski via 8bd6ce9 July 20, 2023 21:06
@wsipak wsipak requested a review from nashif as a code owner July 20, 2023 21:06
@wsipak
boards: arm: add docs for efm32gg_sltb009a
1b9b96f 
This adds the index page and an image of the board.

Signed-off-by: Wojciech Sipak <wsipak@antmicro.com>
@wsipak
Copy link
Contributor Author

wsipak commented Jul 21, 2023

@fabiobaltieri
Sure, I've added a documentation page, and it can be viewed here:
https://builds.zephyrproject.io/zephyr/pr/60137/docs/boards/arm/efm32gg_sltb009a/doc/index.html
Thank you!

@carlescufi carlescufi merged commit 14b91d6 into zephyrproject-rtos:main Jul 25, 2023
20 checks passed
@fkokosinski fkokosinski deleted the wsip/efm32gg12b branch July 25, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiobaltieri fabiobaltieri fabiobaltieri approved these changes

@tgorochowik tgorochowik tgorochowik approved these changes

@fkokosinski fkokosinski fkokosinski left review comments

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

@galak galak Awaiting requested review from galak

@ioannisg ioannisg Awaiting requested review from ioannisg

@nashif nashif Awaiting requested review from nashif

Assignees

@fkokosinski fkokosinski

Labels
manifest manifest-hal_silabs platform: SiLabs Silicon Labs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@wsipak @zephyrbot @fkokosinski @fabiobaltieri @tgorochowik @carlescufi