drivers: kscan: mchp: low power mode enabled #60806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manimaran-A
requested review from
albertofloyd,
MaureenHelm and
galak
as code owners
|
@albertofloyd could you please help to review? |
|
@jvasanth1 @albertofloyd will you please take a look? |
drivers/kscan/kscan_mchp_xec.c
Outdated
| @@ -411,6 +418,9 @@ void polling_task(const struct device *dev, void *dummy2, void *dummy3) | |||
| /* Allow other threads to run while we sleep */ | |||
| k_usleep(wait_period); | |||
| } | |||
| #ifdef CONFIG_PM_DEVICE | |||
There was a problem hiding this comment.
nit, do we need to space ifdef like this?
There was a problem hiding this comment.
Ok, removed the space before #ifdef.
albertofloyd
previously approved these changes
Aug 24, 2023
jvasanth1
previously approved these changes
Aug 25, 2023
|
@Manimaran-A could you rebase please? |
pinctrl and dts updated to support low power feature Signed-off-by: Manimaran A <manimaran.a@microchip.com>
KSCAN driver updated to support low power feature Signed-off-by: Manimaran A <manimaran.a@microchip.com>
Manimaran-A
dismissed stale reviews from jvasanth1 and albertofloyd
via
8207b3d
Manimaran-A
force-pushed
the
xec_kscan_low_power
branch
from
96b2d05
to
8207b3d
Compare
|
@albertofloyd @jvasanth1 Could you please re-approve the PR |
jvasanth1
approved these changes
Aug 29, 2023
carlescufi
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated KSCAN driver and dts files to support low power feature.