Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: sensor: adiltc2990: add adi ltc2990 support #60842

Conversation

jilaypandya
Copy link
Contributor

@jilaypandya jilaypandya commented Jul 26, 2023

This PR adds basic support of analog devices LTC2990 Quad I2C Voltage, Current and Temperature Monitor.
This sensor was tested with MIMXRT1062xxx6A for monitoring 4 single ended voltages with following output.
image

@zephyrbot zephyrbot added area: Devicetree Binding PR modifies or adds a Device Tree binding area: Sensors Sensors labels Jul 26, 2023
@jilaypandya jilaypandya force-pushed the feature/add-analogdevices-ltc2990-support branch 2 times, most recently from 68c4887 to 0c8db7b Compare July 26, 2023 18:54
@jilaypandya jilaypandya changed the title drivers: sensor: adiltc2990 add adi ltc2990 support drivers: sensor: adiltc2990: add adi ltc2990 support Jul 26, 2023
@jilaypandya jilaypandya force-pushed the feature/add-analogdevices-ltc2990-support branch 5 times, most recently from 9292ccc to 203f730 Compare July 28, 2023 06:54
Copy link
Member

@MaureenHelm MaureenHelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Please combine commits drivers: sensor: adds adltc2990 to CMakeLists.txt and Kconfig and driver: sensor: adds basic support for analog devices ltc2990. You also need to add this sensor to tests/drivers/build_all/sensor/i2c.dtsi to build the driver in CI.

drivers/sensor/CMakeLists.txt Outdated Show resolved Hide resolved
dts/bindings/sensor/adi,adltc2990.yaml Outdated Show resolved Hide resolved
dts/bindings/sensor/adi,adltc2990.yaml Outdated Show resolved Hide resolved
drivers/sensor/adltc2990/Kconfig Outdated Show resolved Hide resolved
drivers/sensor/adltc2990/Kconfig Outdated Show resolved Hide resolved
drivers/sensor/adltc2990/adltc2990.c Outdated Show resolved Hide resolved
drivers/sensor/adltc2990/adltc2990.c Outdated Show resolved Hide resolved
drivers/sensor/adltc2990/adltc2990.h Outdated Show resolved Hide resolved
@jilaypandya jilaypandya force-pushed the feature/add-analogdevices-ltc2990-support branch 3 times, most recently from 42b82bd to 461e5be Compare August 1, 2023 07:12
@jilaypandya jilaypandya marked this pull request as draft August 1, 2023 12:54
@jilaypandya jilaypandya force-pushed the feature/add-analogdevices-ltc2990-support branch from 461e5be to 67442c2 Compare August 9, 2023 13:17
@jilaypandya jilaypandya marked this pull request as ready for review August 9, 2023 13:19
@jilaypandya jilaypandya force-pushed the feature/add-analogdevices-ltc2990-support branch from 67442c2 to bb1991e Compare August 9, 2023 14:28
dts/bindings/sensor/adi,adltc2990.yaml Outdated Show resolved Hide resolved
dts/bindings/sensor/adi,adltc2990.yaml Outdated Show resolved Hide resolved
drivers/sensor/adltc2990/adltc2990.c Outdated Show resolved Hide resolved
drivers/sensor/adltc2990/adltc2990.c Outdated Show resolved Hide resolved
drivers/sensor/adltc2990/adltc2990.c Show resolved Hide resolved
drivers/sensor/adltc2990/adltc2990.c Outdated Show resolved Hide resolved
dts/bindings/sensor/adi,adltc2990.yaml Outdated Show resolved Hide resolved
@jilaypandya jilaypandya force-pushed the feature/add-analogdevices-ltc2990-support branch from bb1991e to 0310557 Compare August 18, 2023 18:06
@jilaypandya jilaypandya force-pushed the feature/add-analogdevices-ltc2990-support branch from 0310557 to e65ebda Compare August 18, 2023 18:14
@jilaypandya jilaypandya force-pushed the feature/add-analogdevices-ltc2990-support branch 3 times, most recently from 2dc66e9 to c27b8f0 Compare August 23, 2023 18:03
@jilaypandya jilaypandya force-pushed the feature/add-analogdevices-ltc2990-support branch from c27b8f0 to 28c92e1 Compare September 8, 2023 15:41
@zephyrbot zephyrbot added the platform: ADI Analog Devices, Inc. label Sep 8, 2023
drivers/sensor/adltc2990/CMakeLists.txt Outdated Show resolved Hide resolved
drivers/sensor/adltc2990/adltc2990.c Outdated Show resolved Hide resolved
drivers/sensor/adltc2990/adltc2990.h Outdated Show resolved Hide resolved
drivers/sensor/adltc2990/adltc2990.h Outdated Show resolved Hide resolved
@jilaypandya jilaypandya force-pushed the feature/add-analogdevices-ltc2990-support branch 3 times, most recently from 3d7f290 to 89bb77e Compare September 8, 2023 20:36
@jilaypandya jilaypandya force-pushed the feature/add-analogdevices-ltc2990-support branch from 89bb77e to 11def69 Compare September 11, 2023 17:00
@jilaypandya
Copy link
Contributor Author

jilaypandya commented Sep 11, 2023

@MaureenHelm @yperess,
Hello All :-),

I have incorporated the requested changes, hope the PR is fine now. Would be great if could get a further review or approval:-)

@jilaypandya jilaypandya force-pushed the feature/add-analogdevices-ltc2990-support branch 2 times, most recently from ed9a3e6 to 8702626 Compare September 12, 2023 08:52
Copy link
Member

@MaureenHelm MaureenHelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking better, thank you!

dts/bindings/sensor/adi,adltc2990.yaml Show resolved Hide resolved
dts/bindings/sensor/adi,adltc2990.yaml Show resolved Hide resolved
dts/bindings/sensor/adi,adltc2990.yaml Show resolved Hide resolved
drivers/sensor/adltc2990/adltc2990.c Outdated Show resolved Hide resolved
drivers/sensor/adltc2990/adltc2990.c Outdated Show resolved Hide resolved
drivers/sensor/adltc2990/adltc2990.c Outdated Show resolved Hide resolved
drivers/sensor/adltc2990/adltc2990.c Outdated Show resolved Hide resolved
drivers/sensor/adltc2990/adltc2990.h Outdated Show resolved Hide resolved
@jilaypandya jilaypandya force-pushed the feature/add-analogdevices-ltc2990-support branch from 8702626 to 9874e83 Compare September 13, 2023 05:46
This commit adds adi,adltc2990.yaml to dts/bindings/sensor.

Signed-off-by: Jilay Pandya <jilay.pandya@zeiss.com>
@jilaypandya jilaypandya force-pushed the feature/add-analogdevices-ltc2990-support branch from 9874e83 to 669c253 Compare September 13, 2023 06:07
This commit adds Kconfig variables to configure ADLTC2990. This commit adds
basic driver code for analog devices ltc2990 sensor.

Signed-off-by: Jilay Pandya <jilay.pandya@zeiss.com>
@jilaypandya jilaypandya force-pushed the feature/add-analogdevices-ltc2990-support branch from 669c253 to c788457 Compare September 14, 2023 16:44
@carlescufi carlescufi merged commit 3384ebb into zephyrproject-rtos:main Sep 18, 2023
17 checks passed
@schlotter schlotter deleted the feature/add-analogdevices-ltc2990-support branch September 19, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Devicetree Binding PR modifies or adds a Device Tree binding area: Sensors Sensors platform: ADI Analog Devices, Inc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants