Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subsys:usb:device:audio: Support volume control #60973

Merged
merged 3 commits into from Sep 21, 2023
Merged

subsys:usb:device:audio: Support volume control #60973

merged 3 commits into from Sep 21, 2023

Conversation

SawXu
Copy link
Contributor

@SawXu SawXu commented Jul 31, 2023

Makes USB device audio class support volume control feature.

github-actions[bot]
github-actions bot reviewed Jul 31, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @SawXu, and thank you very much for your first pull request to the Zephyr project!

A project maintainer just triggered our CI pipeline to run it against your PR and ensure it's compliant and doesn't cause any issues. You might want to take this opportunity to review the project's Contributor Expectations and make any updates to your pull request if necessary. 😊

@SawXu SawXu marked this pull request as ready for review July 31, 2023 07:39
@zephyrbot zephyrbot added area: Devicetree Binding PR modifies or adds a Device Tree binding area: USB Universal Serial Bus labels Jul 31, 2023
@SawXu SawXu force-pushed the feat/usb_audio_support_volume_control branch 4 times, most recently from 7be5aa8 to 33f5564 Compare July 31, 2023 10:06
tmon-nordic
tmon-nordic requested changes Jul 31, 2023
View reviewed changes
subsys/usb/device/class/audio/Kconfig Outdated Show resolved Hide resolved
subsys/usb/device/class/audio/audio.c Show resolved Hide resolved
@SawXu SawXu force-pushed the feat/usb_audio_support_volume_control branch 2 times, most recently from 9440008 to d05df43 Compare July 31, 2023 11:07
tmon-nordic
tmon-nordic requested changes Jul 31, 2023
View reviewed changes
subsys/usb/device/class/audio/audio.c Outdated Show resolved Hide resolved
subsys/usb/device/class/audio/Kconfig Outdated Show resolved Hide resolved
@SawXu SawXu force-pushed the feat/usb_audio_support_volume_control branch 4 times, most recently from 2d14af9 to 41980c2 Compare August 1, 2023 09:59
jfischer-no
jfischer-no requested changes Aug 1, 2023
View reviewed changes
subsys/usb/device/class/audio/Kconfig Outdated Show resolved Hide resolved
subsys/usb/device/class/audio/audio.c Outdated Show resolved Hide resolved
subsys/usb/device/class/audio/audio.c Outdated Show resolved Hide resolved
subsys/usb/device/class/audio/audio.c Outdated Show resolved Hide resolved
@SawXu SawXu force-pushed the feat/usb_audio_support_volume_control branch from 41980c2 to 3a5397d Compare August 2, 2023 08:37
@SawXu SawXu force-pushed the feat/usb_audio_support_volume_control branch from 3a5397d to ebdb02f Compare August 3, 2023 03:52
@SawXu SawXu force-pushed the feat/usb_audio_support_volume_control branch 2 times, most recently from 4948969 to 29d6b78 Compare August 14, 2023 06:45
@SawXu SawXu force-pushed the feat/usb_audio_support_volume_control branch from 29d6b78 to a123138 Compare August 15, 2023 03:11
@SawXu
dts: bindings: usb_audio: Add volume properties
1219562 
Add volume feature specific fields. So remove this outdated description.

Signed-off-by: Saw Xu <Saw1993@126.com>
@SawXu SawXu force-pushed the feat/usb_audio_support_volume_control branch from a123138 to 4c96dfe Compare August 15, 2023 03:12
tmon-nordic
tmon-nordic previously approved these changes Aug 16, 2023
View reviewed changes
jfischer-no
jfischer-no previously approved these changes Sep 15, 2023
View reviewed changes
subsys/usb/device/class/audio/audio.c Outdated Show resolved Hide resolved
@SawXu
usb: device: audio: Support volume control
886a932 
Makes USB device audio class support volume control feature.

Signed-off-by: Saw Xu <Saw1993@126.com>
@SawXu
samples: subsys: usb: audio: Add volume control case
43e4492 
Add sample code for getting volume to headset sample and
headphone_microphone sample

Signed-off-by: Saw Xu <Saw1993@126.com>
@SawXu SawXu dismissed stale reviews from jfischer-no and tmon-nordic via 43e4492 September 15, 2023 11:38
@SawXu SawXu force-pushed the feat/usb_audio_support_volume_control branch from 4c96dfe to 43e4492 Compare September 15, 2023 11:38
@jfischer-no jfischer-no added this to the v3.5.0 milestone Sep 15, 2023
@carlescufi carlescufi merged commit 8951bab into zephyrproject-rtos:main Sep 21, 2023
15 checks passed
@github-actions
Copy link

Hi @SawXu!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@jfischer-no jfischer-no jfischer-no approved these changes

@tmon-nordic tmon-nordic tmon-nordic approved these changes

@galak galak Awaiting requested review from galak

Assignees

@jfischer-no jfischer-no

Labels
area: Devicetree Binding PR modifies or adds a Device Tree binding area: USB Universal Serial Bus
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SawXu @jfischer-no @tmon-nordic @carlescufi @zephyrbot