Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: timer: Add TI J721e DM TIMER support #61020

Conversation

slpp95prashanth
Copy link
Contributor

@slpp95prashanth slpp95prashanth commented Aug 1, 2023

In J721e, R5 cores does not have arch timer for
systick. Add DM Timer for systick timer support.

TRM for J721e https://www.ti.com/lit/zip/spruil1
File: spruil1c.pdf
TImer: section 12.10

BeagleBone AI_64 https://beagleboard.org/ai-64

@slpp95prashanth slpp95prashanth force-pushed the zephyr_dmtimer branch 2 times, most recently from 969c880 to 9a7ce95 Compare August 1, 2023 07:41
@vaishnavachath vaishnavachath self-requested a review August 1, 2023 08:19
unsigned int sys_clock_elapsed(void)
{
return 0;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slpp95prashanth I don't think this can be empty.
Also missing sys_clock_set_timeout() implementation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vaishnavachath
sys_clock_elapsed returns zero if TICKLESS_CAPABLE is disabled.

sys_clock_set_timeout() is required for TICKLESS_CAPABLE option. I tested the threads and time features seems to work. I thought of adding TICKLESS_CAPABLE once initial support is merged. Shall I add it after the soc, board, device tree, interrupt controller and timers PR are merged?

include/zephyr/drivers/timer/ti_j721e_dmtimer.h Outdated Show resolved Hide resolved
drivers/timer/Kconfig Outdated Show resolved Hide resolved
drivers/timer/CMakeLists.txt Outdated Show resolved Hide resolved
@slpp95prashanth
Copy link
Contributor Author

This PR depends on the #60856.

@slpp95prashanth
Copy link
Contributor Author

The Kconfig, file and compatible names for dmtimer are chosen based on linux kernel.

@vaishnavachath
Copy link
Contributor

@slpp95prashanth Please squash the TICKLESS support commit with the base commit.

TI DM Timer is a dual mode timer, J721E R5 cores does not have
arch timer for systick. Add DM Timer for systick timer
support.

Signed-off-by: Prashanth S <slpp95prashanth@yahoo.com>
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants