ev11l78a: initial import of the UPD301C Basic Sink board. #61140
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @Flameeyes, and thank you very much for your first pull request to the Zephyr project!
A project maintainer just triggered our CI pipeline to run it against your PR and ensure it's compliant and doesn't cause any issues. You might want to take this opportunity to review the project's Contributor Expectations and make any updates to your pull request if necessary. 😊
boards/arm/ev11l78a/ev11l78a.yaml
Outdated
| @@ -0,0 +1,10 @@ | |||
| identifier: ev11l78a | |||
| name: UPC301C Basic Sink Application Example | |||
There was a problem hiding this comment.
| name: UPC301C Basic Sink Application Example | |
| name: UPD301C Basic Sink Application Example |
boards/arm/ev11l78a/doc/index.rst
Outdated
| Overview | ||
| ******** | ||
|
|
||
| The UPD301C Basic Sink Application Example Evaluation Kit is a |
There was a problem hiding this comment.
| The UPD301C Basic Sink Application Example Evaluation Kit is a | |
| The UPD301C Basic Sink Application Example Evaluation Kit (EV11L78A) is a |
boards/arm/ev11l78a/doc/index.rst
Outdated
| ******** | ||
|
|
||
| - ATSAMD20E16 ARM Cortex-M0+ processor at 48 MHz | ||
| - UPD301C combines a SAMD20 core and a UPD350 USB-PD controller. |
There was a problem hiding this comment.
Nit: either end all bullet list items with ., or none
Flameeyes
force-pushed
the
ev11l78a
branch
2 times, most recently
from
38779f7
to
3ad234b
Compare
| @@ -20,6 +20,7 @@ common: | |||
| - wio_terminal | |||
| - xiao_esp32c3 | |||
| - atsamd20_xpro | |||
| - ev11l78a | |||
There was a problem hiding this comment.
The exclusion won't be needed if #61193 makes it to the tree before this pull request.
boards/arm/ev11l78a/doc/index.rst
Outdated
| :align: center | ||
| :alt: EV11L78A | ||
|
|
||
| UPD301C Basic Sink Application Example (Credit: Micropchip Technology) |
There was a problem hiding this comment.
/runner/_work/zephyr/zephyr/doc/_build/src/boards/arm/ev11l78a/doc/index.rst:15: ERROR: Error in "image" directive:
no content permitted.
.. image:: ../../../../../../../boards/arm/ev11l78a/doc/img/ev11l78a.jpg
:align: center
:alt: EV11L78A
UPD301C Basic Sink Application Example (Credit: Micropchip Technology)
I think this line is not indented correctly? The error sound funny
There was a problem hiding this comment.
indentation was correct, but only figure:: accept contents (the description of the figure), and this originally used image::
There was a problem hiding this comment.
Yeah I eventually found that out — I plan on taking the various suggestions from this pull request and see to update at least atsamd20_xpro (which I used as source for most of it) to follow the same style.
Flameeyes
force-pushed
the
ev11l78a
branch
7 times, most recently
from
577cdd2
to
be9e7f4
Compare
| CONFIG_GPIO=y | ||
| CONFIG_SOC_ATMEL_SAMD_OSC8M=y | ||
| CONFIG_SOC_ATMEL_SAMD_OSC8M_AS_MAIN=y | ||
| CONFIG_ADC=y |
There was a problem hiding this comment.
This should probably not be here, but rather be enabled by specific samples or applications requiring the ADC.
This board is a relatively inexpensive development kit for USB-PD controllers, using an UPD301C controller. This Zephyr config includes support for: * UART (present on he debug header of the board), tested with the hello_world sample application; * the one standalone LED (CAP_MIS), tested with the blinky sample application; * the rotary encoder (PDO_SEL), via ADC, tested with the adc sample application; * the current sense amplifier (I_SENSE), currently untested; * the SPI bus, connected internally in the UPD301C to the UPD350; * the I2C bus, exposed on the debug header, currently untested. Note that the drivers.uart.async_api.rtt has to be disabled, as it is for other m0 boards with no dma or it fails to build. Signed-off-by: Diego Elio Pettenò <flameeyes@meta.com>
There was a problem hiding this comment.
Hi @Flameeyes!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!
To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.
Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁
This updates the configurations for these two boars to match the expected best practices for new boards, as discussed in zephyrproject-rtos#61140. Signed-off-by: Diego Elio Pettenò <flameeyes@meta.com>
This updates the configurations for these two boars to match the expected best practices for new boards, as discussed in zephyrproject-rtos#61140. Signed-off-by: Diego Elio Pettenò <flameeyes@meta.com>
This updates the configurations for these two boars to match the expected best practices for new boards, as discussed in zephyrproject-rtos#61140. Signed-off-by: Diego Elio Pettenò <flameeyes@meta.com>
This updates the configurations for these two boars to match the expected best practices for new boards, as discussed in #61140. Signed-off-by: Diego Elio Pettenò <flameeyes@meta.com>
This updates the configurations for these two boars to match the expected best practices for new boards, as discussed in zephyrproject-rtos#61140. Signed-off-by: Diego Elio Pettenò <flameeyes@meta.com>
This updates the configurations for these two boars to match the expected best practices for new boards, as discussed in zephyrproject-rtos#61140. Signed-off-by: Diego Elio Pettenò <flameeyes@meta.com>
This board is a relatively inexpensive development kit for USB-PD
controllers, using an UPD301C controller.
This Zephyr config includes support for the UART (present on the debug
header of the board), and for the one simple LED (CAP_MIS), both tested
with hello_world and blinky respectively.
Please note that this initial import does not include any other feature
of the board, so no other interaction is available.