Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport v2.7-branch] canbus: isotp: convert SF length check from ASSERT to runtime check #61516

Merged
merged 1 commit into from Aug 25, 2023
Merged

[Backport v2.7-branch] canbus: isotp: convert SF length check from ASSERT to runtime check #61516

merged 1 commit into from Aug 25, 2023

Conversation

zephyrbot
Copy link
Collaborator

@zephyrbot zephyrbot commented Aug 15, 2023 •
edited by henrikbrixandersen

Backport 1b3d1e0 from #61502.

Fixes: #61501

@henrikbrixandersen @github-actions
canbus: isotp: convert SF length check from ASSERT to runtime check
99f10f4 
Convert the ISO-TP SF length check in send_sf() from __ASSERT() to a
runtime check.

Fixes: #61501

Signed-off-by: Henrik Brix Andersen <hebad@vestas.com>
(cherry picked from commit 1b3d1e0)
@zephyrbot zephyrbot added the Backport Backport PR and backport failure issues label Aug 15, 2023
@henrikbrixandersen henrikbrixandersen self-assigned this Aug 15, 2023
@cfriedt cfriedt merged commit 2daec8c into v2.7-branch Aug 25, 2023
22 checks passed
@nashif nashif deleted the backport-61502-to-v2.7-branch branch February 13, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrikbrixandersen henrikbrixandersen henrikbrixandersen approved these changes

@martinjaeger martinjaeger martinjaeger approved these changes

@str4t0m str4t0m str4t0m approved these changes

@alexanderwachter alexanderwachter Awaiting requested review from alexanderwachter alexanderwachter is a code owner

@karstenkoenig karstenkoenig Awaiting requested review from karstenkoenig

@cfriedt cfriedt Awaiting requested review from cfriedt

Assignees

@henrikbrixandersen henrikbrixandersen

Labels
area: CAN Backport Backport PR and backport failure issues
Projects
Backports
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zephyrbot @henrikbrixandersen @martinjaeger @str4t0m @cfriedt