New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
posix: clock_nanosleep implementation #61671
posix: clock_nanosleep implementation #61671
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @TomFinet, and thank you very much for your first pull request to the Zephyr project!
A project maintainer just triggered our CI pipeline to run it against your PR and ensure it's compliant and doesn't cause any issues. You might want to take this opportunity to review the project's Contributor Expectations and make any updates to your pull request if necessary. 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - please just fix compliance issues, failed tests, and please refactor tests in nanosleep.c
a5e24ae
to
1a80edb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this PR includes a significant amount of code formatting / whitespace changes.
Can you please make the whitespace changes in a separate commit, if necessary, or simply undo the formatting changes in your current code commit?
92456f9
to
7b0776b
Compare
Implements the posix clock_nanosleep function, where both relative and absolute sleeps are made as absolute sleeps. The nanosleep() function is a special case of clock_nanosleep(), and so has been refactored to simply call it. Signed-off-by: Tom Finet <tom.codeninja@gmail.com>
7b0776b
to
354234d
Compare
Adds error and lower bounds tests for the posix clock_nanosleep function. Refactors common test functions to be shared by both clock_nanosleep and nanosleep tests. Signed-off-by: Tom Finet <tom.codeninja@gmail.com>
354234d
to
c6e6ca8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM & thanks for your contribution :-)
Implementation of the clock_nanosleep function.
Fixes #59949